[Test] Add makefile_test.py, to verify make in all build-modes.
#19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gapisback
commented
Apr 11, 2024
| run-tests: run-unit-tests run-test-code | ||
| ./test.sh |
There was a problem hiding this comment.
Delete this, otherwise, test.sh will invoke the newly added makefile_test.py, leading to endless recursion in these testing cycles.
Previous commit that introduced support for building with LOC-ELF encoding scheme (i.e, SHA f7e7b10) is only exercising building with the LOC-ELF encoding scheme for a very simple unit-test, unit/single_file_elf_src/single_file_prog_elf_test.c We need a better way to trigger either the default LOC-encoding or the LOC-ELF encoding technique. The approach chosen, to be implemented in subsequent commits, is to flag-off of an env-var, LOC_ENABLED={1,2}. Default mode, with this env-var unset is to use default LOC-encoding. This commit adds a collection of `make` build-mode pytest cases to exercise `make` with diff env-variables, such as: # Default build mode, using Python generator. 1. $ make # Default LOC-encoding, using Python generator. 2. $ LOC_ENABLED=1 make ... # LOC-ELF encoding, w/o using Python generator. 3. $ LOC_ENABLED=2 make ... The test cases carefully verify that: a) The required files are generated in the expected sub-dirs for (1) and (2) b) The Python generator is _not_ invoked for (3), i.e., no generated files are found after the `make` completes. The sources compile because the provided src/loc.c and include/loc.h are used to build all the sample / unit-test programs. Some of these test cases are failing so are currently skipped with this commit. Future changes will be applied to fix the `make` build rules issues, enabling failing tests. Fix pylint errors found in CI.
gapisback
force-pushed
the
gapisback/Fix-LOC-ELF-cpp
branch
from
393854f
to
9a5aabe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous commit that introduced support for building with LOC-ELF encoding scheme (i.e, SHA f7e7b10) is only exercising building with the LOC-ELF encoding scheme for a very simple unit-test,
unit/single_file_elf_src/single_file_prog_elf_test.cWe need a better way to trigger either the default LOC-encoding or the LOC-ELF encoding technique. The approach chosen, to be implemented in subsequent commits, is to flag-off of an env-var,
LOC_ENABLED={1,2}.Default mode, with this env-var unset is to use default LOC-encoding.
This commit adds a collection of
makebuild-mode pytest cases to exercisemakewith diff env-variables, such as:The test cases carefully verify that:
a) The required files are generated in the expected sub-dirs for (1) and (2)
b) The Python generator is not invoked for (3), i.e., no generated files
are found after the
makecompletes. The sources compile because the provided src/loc.c and include/loc.h are used to build all the sample / unit-test programs.Some of these test cases are failing so are currently skipped with this commit. Future changes will be applied to fix the
makebuild rules issues, enabling failing tests.