Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log client IP in failed accesses #1122

Merged
merged 8 commits into from
May 13, 2020
Merged

Log client IP in failed accesses #1122

merged 8 commits into from
May 13, 2020

Conversation

benrubson
Copy link
Contributor

Hello,

This PR adds the client IP in the LH_AUTH_NG message, the authentication failure message.
This allow to use tools such as Fail2Ban to ban IPs with too many authentication failures / retries.

Thank you very much for your help & support 馃憤


Same as SoftEtherVPN/SoftEtherVPN_Stable#8

@benrubson
Copy link
Contributor Author

Note that I did not updated strtable_cn.stb & strtable_ja.stb files, as I don't know really know how to deal with them, feel free then :)
Thank you 馃憤

@chipitsine
Copy link
Member

can you please duplicate lines from "en" to strtable_cn.stb & strtable_ja.stb ?

I'm afraid otherwise it will break in runtime

@benrubson
Copy link
Contributor Author

Thank you @chipitsine for your review 馃憤
I just modified all strtable_* files with the new error message.
I also performed same modification in the stable PR.
Thank you also @davidebeatrici 馃憤

@chipitsine chipitsine merged commit e3e35f5 into SoftEtherVPN:master May 13, 2020
@benrubson benrubson deleted the ban branch May 13, 2020 10:36
@metalefty
Copy link
Contributor

Thank you for this. This is also useful to me.

@benrubson
Copy link
Contributor Author

Also note that we however suffer from the limitation described there : #260

@benrubson
Copy link
Contributor Author

Fail2Ban jail merged 馃憤 fail2ban/fail2ban#2723

@davidebeatrici
Copy link
Member

Awesome, thanks!

metalefty added a commit to metalefty/SoftEtherVPN that referenced this pull request Nov 10, 2020
metalefty added a commit to metalefty/SoftEtherVPN that referenced this pull request Nov 10, 2020
@benrubson
Copy link
Contributor Author

Thanks too !
Feel free @davidebeatrici if you have an idea / have time to help with #260 (comment) :)
That's the last log system limitation we have...
Thank you again 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants