Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Traditional Chinese language translation #154

Merged
merged 5 commits into from Feb 15, 2018

Conversation

holoreimu
Copy link
Contributor

Since there are many users from Taiwan, I add the Traditional Chinese language translation.

Add Traditional Chinese language
Add Traditional Chinese language
@moatazelmasry2
Copy link
Member

Your great patch is much appreciated. We are considering to apply your patch into the SoftEther VPN main tree.

SoftEther VPN Patch Acceptance Policy:
http://www.softether.org/5-download/src/9.patch

You have two options which are described on the above policy.
Could you please choose either option 1 or 2, and specify it clearly on the reply?

@moatazelmasry2
Copy link
Member

Thanks for your patch. Could you please align your code to have the same amount of space as the rest of code???

*align the code to have same amout of space
*update some translation to latest version
@holoreimu
Copy link
Contributor Author

Hi,

Thanks for considering my patch into SoftEther VPN main tree.
About the option, I choose 1.

If there are still any problem within my code, please kindly inform me.

Thanks.

@moatazelmasry2
Copy link
Member

No it looks good from my side. Now I need someone who understands traditional Chinese to actually review the content of the translation. Also we need one more thumb up before merging this PR

@rtau
Copy link
Contributor

rtau commented Jan 24, 2018

I could read both Chinese and English. Maybe let me try to review the translation.

PRODUCT_NAME_VPN_BRIDGE SoftEther VPN Bridge Developer Edition
PRODUCT_NAME_VPN_SMGR SoftEther VPN Developer Edition Server 管理器
PRODUCT_NAME_ELOGSVC SoftEther EtherLogger Developer Edition
PRODUCT_NAME_ELOGMGR SoftEther EtherLogger Developer Edition
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplified Chinese: PRODUCT_NAME_ELOGMGR SoftEther EtherLogger Developer Edition 管理器
English: PRODUCT_NAME_ELOGMGR SoftEther EtherLogger Developer Edition

@rtau
Copy link
Contributor

rtau commented Feb 13, 2018

So far, I have only read the list of ERR_ messages and skimmed through the rest. No obvious problem so far.

@moatazelmasry2 moatazelmasry2 merged commit b8f0dd9 into SoftEtherVPN:master Feb 15, 2018
@moatazelmasry2
Copy link
Member

Thank you very much. Your great PR has been merged into the master branch. As a token of gratitude your name will be added to the authors list.

Again thank you very much for your hard work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants