Fix M141 S0 at end of gcode #2328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ocraftyone |
SoftFever
requested changes
Oct 5, 2023
Thanks 😄 |
Ocraftyone
force-pushed
the
patch-remove-hardcoded-chamber-temp
branch
from
705f723
to
a6d0458
Compare
|
I looked through the gui and searched the project and only found one mention of support_chamber_temp_control, so I have it so that it will disable the heated chamber either if the support chamber temp flag is thrown or if the chamber temp was set above 0 |
SoftFever
approved these changes
Oct 5, 2023
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2306 where gcode to turn off chamber heating is hardcoded into the slicer. BBS has also removed this line of code in their source.