Show as much information as possible in crash log #2386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noisyfox
force-pushed
the
dev/crash-log-improve
branch
from
a546cfd
to
a8700d5
Compare
SoftFever
reviewed
Oct 11, 2023
| @@ -492,7 +492,8 @@ LPSTACKINFO CStackWalker::StackWalker(HANDLE hThread, const CONTEXT* context) | |||
| { | |||
| //调用错误一般是487(地址无效或者没有访问的权限、在符号表中未找到指定地址的相关信息) | |||
| this->OutputString(_T("Call SymGetSymFromAddr64 ,Address %08x Error:%08x\r\n"), sf.AddrPC.Offset, GetLastError()); | |||
| continue; | |||
SoftFever
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In issue #2384 the crash log indicates
SymGetLineFromAddr64failed, which meansSymGetSymFromAddr64must be successful. However, the symbol is not output because line number is not available, which doesn't make any sense and makes debugging much harder.We should try to output as much information in the log as possible, because any extra information is better than no information.