Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for QOI thumbnails not working #2755

Merged
merged 1 commit into from Nov 16, 2023
Merged

Fix for QOI thumbnails not working #2755

merged 1 commit into from Nov 16, 2023

Conversation

Exerqtor
Copy link
Contributor

Should remedy the issues mentioned in #2741

@Exerqtor
Fix for QOI not working
f2daf08 
Should remidy the issues in SoftFever#2741
Ocraftyone
Ocraftyone approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@Ocraftyone Ocraftyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Noisyfox Noisyfox linked an issue Nov 16, 2023 that may be closed by this pull request
Thumbnail don't work for RRF #2741
Closed
2 tasks
@SoftFever
Copy link
Owner

@Exerqtor Thanks for the fix 👍
@Noisyfox @Ocraftyone Thanks for the review

@SoftFever SoftFever merged commit f61c504 into SoftFever:main Nov 16, 2023
@lbibass
Copy link
Contributor

lbibass commented Nov 16, 2023 •
edited

This change broke PNG uploads to klipper.

Reverting this commit restored PNGs.
Screenshot 2023-11-16 at 12 33 05 PM

@SoftFever
Copy link
Owner

This change broke PNG uploads to klipper.

Reverting this commit restored PNGs. Screenshot 2023-11-16 at 12 33 05 PM

Nice catch.
It broken all thumbnails.
Fixed in 9505f93

PilotMatt added a commit to printago/OrcaSlicer-PrintagoEdition that referenced this pull request Dec 4, 2023
@PilotMatt
Squashed commit of the following:
655591e 
commit 7c0a061
Author: SoftFever <softfeverever@gmail.com>
Date:   Sun Dec 3 20:23:55 2023 +0800

    Fix mac notary

commit be1bd08
Author: SoftFever <softfeverever@gmail.com>
Date:   Sun Dec 3 09:20:29 2023 +0800

    Fix precise wall for Arachne wall generator (SoftFever#2966)

    Update WIKI for it

commit f052206
Author: SoftFever <softfeverever@gmail.com>
Date:   Sat Dec 2 12:45:02 2023 +0800

    Improve PA calibration Line method so it works for bed origin not in (0,0)

commit e502ffa
Author: SoftFever <softfeverever@gmail.com>
Date:   Sat Dec 2 01:47:24 2023 +0800

    Update locale

commit 7237855
Author: SoftFever <softfeverever@gmail.com>
Date:   Thu Nov 30 23:58:52 2023 +0800

    Build release branches

commit a18f42e
Author: SoftFever <softfeverever@gmail.com>
Date:   Sat Dec 2 01:27:22 2023 +0800

    bump version to V1.8.1

commit b4b9805
Author: SoftFever <softfeverever@gmail.com>
Date:   Sat Dec 2 01:27:09 2023 +0800

    disable misleading 3mf version warning

commit e823044
Author: SoftFever <softfeverever@gmail.com>
Date:   Fri Dec 1 23:13:26 2023 +0800

    Improve arc fitting when new overhang slowdown is used (SoftFever#2942)

    (cherry picked from commit 3923b9c)

commit f2f2ede
Author: SoftFever <softfeverever@gmail.com>
Date:   Sat Dec 2 01:27:43 2023 +0800

    thick internal bridges (SoftFever#2954)

commit 3a8b799
Author: Ioannis Giannakas <59056762+igiannakas@users.noreply.github.com>
Date:   Fri Dec 1 15:50:58 2023 +0000

    Internal Bridge Flow rate parameter introduction

    Updated internal bridging flow change and reverted bridge PR (SoftFever#2943)

    Updated internal bridging flow change & reverted bridge PR

    (cherry picked from commit ae9a2d5)
    Internal Bridge Flow rate parameter introduction (SoftFever#2859)

    * Internal Bridge Flow rate parameter introduction

    * updated incorrect capitalisation

    * Updated parameter ordering

    (cherry picked from commit ce9a8d7)

commit 5676e0e
Author: SoftFever <softfeverever@gmail.com>
Date:   Sun Nov 19 19:08:04 2023 +0800

    Merge pull request SoftFever#2780 from Noisyfox:bugfix/amd-png

    Fix PNG build plate texture not rendering on AMD GPUs

    (cherry picked from commit 93f62a4)

commit 8829853
Author: SoftFever <softfeverever@gmail.com>
Date:   Fri Dec 1 22:27:27 2023 +0800

    Revert "Adding new nozzle profiles for the Creality Ender-5 Pro (2019) (SoftFever#2817)"

    This reverts commit 09a8fa3.

commit 09a8fa3
Author: Paul <pwschattenberg@users.noreply.github.com>
Date:   Wed Nov 29 15:32:58 2023 +0100

    Adding new nozzle profiles for the Creality Ender-5 Pro (2019) (SoftFever#2817)

    * Add 0.6mm Nozzle Configurations for CE5Pro

    * Add 0.5mm Nozzle Configurations for CE5Pro

    * Add Nozzle Size Printer Variants 0.2-1.0mm

    * Add 0.3mm Printer Variant

    * Add 0.5mm Printer Variant

    * Fix: 0.6mm Printer Variant

    * Add Remaining Printer Variants

    * Add CE5Pro Nozzles to list of Compatible Filament

    * Add Generic FDM Process for Creality 0.3 Nozzle

    * Update Generic FDM Process for Creality 0.6 Nozzle

    * Add FDM Process for Remaining Creality Nozzle

    * Add Processes For CE5Pro 0.8mm Nozzle

    * Add Processes For CE5Pro 1.0mm Nozzle

    * Add Processes For CE5Pro 0.2mm Nozzle

    * Fix Initial Layer Settings

    * Add Processes For CE5Pro 0.25mm Nozzle

    * Add Processes For CE5Pro 0.3mm Nozzle

    * Remove Profiles Outside their Min/Max Layer Height

    * Update CE5Pro 0.4 Nozzle Naming Scheme to PR1100

    * Update CE5Pro 0.2 Nozzle Naming Scheme to PR1100

    * Update CE5Pro 0.25 Nozzle Naming Scheme to PR1100

    * Update CE5Pro 0.3 Nozzle Naming Scheme to PR1100

    * Update CE5Pro 0.5 Nozzle Naming Scheme to PR1100

    * Update CE5Pro 0.6 Nozzle Naming Scheme to PR1100

    * Update CE5Pro 0.8 Nozzle Naming Scheme to PR1100

    * Update CE5Pro 1.0 Nozzle Naming Scheme to PR1100

    * Incl. Remaining Base Config That Diff Is Based On

    * Remove whitespace

    (cherry picked from commit eab8139)

commit 4dbd866
Author: Andy <andylg@yandex.ru>
Date:   Wed Nov 29 21:33:52 2023 +0700

    Russian translation update OrcaSlicer V1.8.0 Release. (SoftFever#2873)

    * Russian translation update

    Russian translation update

    * Russian translation update

    Russian translation update

    (cherry picked from commit 48c9143)

commit c122c76
Author: Trist0ne <41755299+Trist0ne@users.noreply.github.com>
Date:   Wed Nov 29 09:35:30 2023 -0500

    T500 profile fixes and optimizations (SoftFever#2848)

    Corrected corrupted buildplate texture, corrected too high accelerations that made printing 0.4mm impossible, optimized T500 print and filament profiles with testing

    (cherry picked from commit 10a0f58)

commit 79a7221
Author: FlashforgeOfficial <144670305+FlashforgeOfficial@users.noreply.github.com>
Date:   Wed Nov 29 22:36:09 2023 +0800

    Flashforge: Machine G-code Fix (SoftFever#2922)

    Machine G-code Fix

    (cherry picked from commit 930eac0)

commit 5f89963
Author: Ioannis Giannakas <59056762+igiannakas@users.noreply.github.com>
Date:   Mon Nov 27 13:39:16 2023 +0000

    Fix crash when closing application  (SoftFever#2904)

    * Update GUI_ObjectList.cpp

    * Update GUI_ObjectList.cpp

    (cherry picked from commit d71eaf9)

commit b5b5e03
Author: Ioannis Giannakas <59056762+igiannakas@users.noreply.github.com>
Date:   Tue Nov 28 12:44:29 2023 +0000

    Fix purging not working for BBL printers (SoftFever#2912)

commit f5ec607
Author: SoftFever <softfeverever@gmail.com>
Date:   Fri Nov 17 20:00:12 2023 +0800

    update WIKI

commit cb038d0
Author: SoftFever <softfeverever@gmail.com>
Date:   Fri Nov 17 20:00:05 2023 +0800

    fix Prusa MK3S and Mini profile issues
    Fixed SoftFever#2768

commit 698440d
Author: mariuske <mariuskeliassen@gmail.com>
Date:   Fri Nov 17 12:40:03 2023 +0100

    Removed print_flow_ratio from Flashforge process (SoftFever#2769)

    For some reason this value stayed in this profile file after a recent merge and it's now been removed again.

commit b264203
Author: Noisyfox <timemanager.rick@gmail.com>
Date:   Fri Nov 17 14:28:48 2023 +0800

    Fix creality k1/max default materials (SoftFever#2609) (SoftFever#2767)

commit 4dcfd97
Author: SVNMLR <44621949+SVNMLR@users.noreply.github.com>
Date:   Fri Nov 17 01:01:52 2023 +0100

    [Multi Material] Fix first layers of prime tower when using "no sparse layers" (SoftFever#2764)

    * MM - Add check for first layer

    * Change: If no sparse layer is on -> Respect the toolchange in the first-layer checkup, to use a brim and slow down printspeed if using a primetower

    * Fix comment

commit 9505f93
Author: SoftFever <softfeverever@gmail.com>
Date:   Fri Nov 17 07:54:59 2023 +0800

    fix thumbnails regression

commit bc05653
Author: SoftFever <softfeverever@gmail.com>
Date:   Thu Nov 16 23:25:28 2023 +0800

    orca bot: processing issues in ascending order

commit 9af22da
Author: SoftFever <softfeverever@gmail.com>
Date:   Thu Nov 16 23:17:59 2023 +0800

    bump version to 1.8

commit 09c77c4
Author: SoftFever <softfeverever@gmail.com>
Date:   Thu Nov 16 23:02:10 2023 +0800

    update profile version to 1.08.00.00

commit 6c957d4
Author: mariuske <mariuskeliassen@gmail.com>
Date:   Thu Nov 16 15:07:02 2023 +0100

    Restructured Flashforge process profiles (SoftFever#2718)

    * Restructured Flashforge process profiles

    * Fixed typo in machine profiles

    * Changed skirt loops to 2

    Based on best practise (other profiles), I have changed the number of skirt loops from 1 to 2

commit 75c019a
Author: Andy <andylg@yandex.ru>
Date:   Thu Nov 16 21:02:13 2023 +0700

    Russian translation update (SoftFever#2760)

    Russian translation update

commit 7566df5
Author: SoftFever <softfeverever@gmail.com>
Date:   Thu Nov 16 19:42:30 2023 +0800

    fix snapmaker J1 not displaying bug
    fixed SoftFever#2750

commit 2fc5a7d
Author: Noisyfox <timemanager.rick@gmail.com>
Date:   Thu Nov 16 19:15:37 2023 +0800

    Fix layer height modifier layout (SoftFever#2708) (SoftFever#2756)

commit 565732a
Author: SoftFever <softfeverever@gmail.com>
Date:   Thu Nov 16 19:07:40 2023 +0800

    remove print_flow_ratio from profiles and hide it from process setting. It should be only displayed for parts

commit e8ac157
Author: FlyingbearOfficial <150423627+FlyingbearOfficial@users.noreply.github.com>
Date:   Thu Nov 16 18:46:32 2023 +0800

    Flyingbear official patch 9 (SoftFever#2746)

    * Add a new brand named Flyingbear

    Add a new brand named Flyingbear
    Model name: Flyingbear Reborn3

    * Update fdm_machine_common.json

    fix
    z_hop 0,2(2)

    * make bed model smaller and set default internal_solid_infill_pattern to monotonic

    ---------

    Co-authored-by: SoftFever <softfeverever@gmail.com>

commit 24ae038
Author: Fabio Forcina <f.fabietto@gmail.com>
Date:   Thu Nov 16 11:18:50 2023 +0100

    Italian translation (SoftFever#2706)

    * Update OrcaSlicer_it.po

    * Italian translation

    Italian translation

    * fix errors

    ---------

    Co-authored-by: SoftFever <softfeverever@gmail.com>

commit f61c504
Author: Exerqtor <41635644+Exerqtor@users.noreply.github.com>
Date:   Thu Nov 16 11:13:08 2023 +0100

    Fix for QOI thumbnails not working (SoftFever#2755)

    Fix for QOI not working

    Should remidy the issues in SoftFever#2741
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noisyfox Noisyfox Noisyfox approved these changes

@Ocraftyone Ocraftyone Ocraftyone approved these changes

@SoftFever SoftFever SoftFever approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Thumbnail don't work for RRF
5 participants
@Exerqtor @SoftFever @lbibass @Noisyfox @Ocraftyone