Fuzzy skin fixes + on/off for first layer #2903
Conversation
Adding option to enable/disable fuzzy skin on first layer
|
Overall LGTM. |
| double dist_last_point = dist_left_over + p0p1_size * 2.; | ||
| for (double p0pa_dist = dist_left_over; p0pa_dist < p0p1_size; | ||
| double p0pa_dist = dist_left_over; | ||
| for (; p0pa_dist < p0p1_size; |
There was a problem hiding this comment.
Cura also has these lines:
Do you think it's necessary to add those too?
There was a problem hiding this comment.
This seems to deal with the situation where the line is too small to place a "pa" point on, in which case Cura seems to be placing a "pa" point in the middle of said line.
I feel like here, dist_left_over should deal with that (by accumulating length of short lines until we're eligible to add a "pa" point).
I will take a more in depth look later today. If you have geometry that makes this misbehave, please share, I think that would be really helpful.
There was a problem hiding this comment.
I don't have much experience with this feature TBH so I couldn't give any feedback on this. I think it shouldn't matter too much for most of the models anyway.
I'll approve the PR and if you think it's OK to merge without those lines then just let me know.
There was a problem hiding this comment.
@Noisyfox Those lines are not here anyway in the current state. So I think we should be fine merging as is.
I've been slicing 4-5 different models and printing them perfectly with this PR.
If we have a resident expert on fuzzy skin, we should have them take a look, if not then we should be fine to merge.
There was a problem hiding this comment.
Those lines are not here anyway in the current state. So I think we should be fine merging as is.
Fare enough, and we can always add those later if needed easily. Will merge as is, thanks!
* Fixing fuzzy skin so it doesn't exit the desired geometry at line ends Adding option to enable/disable fuzzy skin on first layer * Whitespace + removing extra file
Fixing fuzzy skin so it doesn't exit the desired geometry at line ends
Adding option to enable/disable fuzzy skin on first layer
Fixes #2891