-
-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a simple subtle outline effect by drawing back faces using wireframe mode #2934
Conversation
Wow, nice!! |
This has been a longtime needed feature, even for PrusaSlicer. You can't see much with many colors of filament. Much appreciated. One question, how does it look with a black filament color? Does the effect still work to make things more visible? |
That's a good question, will take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome
It's expected to also show these outlines in the thumbnail (because I didn't disable the outline when rendering the thumbnails), however the colors are far off. It should be black or white, not red or purple. |
Yeah I'll take a look at the color issue. |
Btw, m1 mac or intel mac? |
M1 Pro 14 inch |
…g wireframe mode (SoftFever#2934)" This reverts commit 0cee513.
So this one also causes significant performance issues on M1 Pro/Max laptops when rendering complex high polygon models. See comment here: |
Yeah and it also has color issue on m1 macs. I think I'll have to disable this on m1 macs then. |
It's not working well for some models on Windows as well. |
Well this is exactly what it should look like with current approach. It only adds outlines to places where front face and back face shares the same edge, not based on the relative angle between two faces. |
After discussing with @Noisyfox, we decided to revert this change for now. |
Works Fine on win. What About to add a new settings to enable/disable? |
This should improve the contrast of the edges and make features more visible.
Some comparisons:
![image](https://private-user-images.githubusercontent.com/1537155/286807722-3059b3a4-272b-43a7-9848-8289b577f7d9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA0NTY2NTMsIm5iZiI6MTcyMDQ1NjM1MywicGF0aCI6Ii8xNTM3MTU1LzI4NjgwNzcyMi0zMDU5YjNhNC0yNzJiLTQzYTctOTg0OC04Mjg5YjU3N2Y3ZDkucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcwOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MDhUMTYzMjMzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NzM1MmNiMTk0YTIxYzI0Yjg3ZDdiMGQwN2NlODVjZjY1MWM0YjdjOTQyNzMzZDExMWJkZTYyOTU3MDU1MjZkYyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.fOMHZJSA4momayyGqMugNN57qElghkUFaIDnxiClTts)
![image](https://private-user-images.githubusercontent.com/1537155/286807827-a07ab211-a134-4353-8494-d2366c725b54.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA0NTY2NTMsIm5iZiI6MTcyMDQ1NjM1MywicGF0aCI6Ii8xNTM3MTU1LzI4NjgwNzgyNy1hMDdhYjIxMS1hMTM0LTQzNTMtODQ5NC1kMjM2NmM3MjViNTQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcwOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MDhUMTYzMjMzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MDNiOWVlMGZlNGVmNTY0NTE2OGI4NmRiYmFhNjY5ZGQ2ZDRjNGUyZjM4MWQ5NmFjMTE1MzMxMmE4MTMzN2VmYyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.52ZORdz1-2KUBJoMJd0pmdQpm2ZjPiNOXctSjAINH-U)