Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug fix] Fixes retraction on layer change being performed when retract travel threshold is set to 0 #3614

Conversation

igiannakas
Copy link
Contributor

@igiannakas igiannakas commented Jan 11, 2024

Fixes #3603

Before:
image

After
image

Before
image

After:
image

@igiannakas igiannakas changed the title Fixes #3603 - retraction on layer change being performed when retract travel threshold is set to 0 [Bug fix] Fixes retraction on layer change being performed when retract travel threshold is set to 0 Jan 12, 2024
@SoftFever
Copy link
Owner

Looks good.
Do you have any idea what initially caused the retraction actions?

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SoftFever SoftFever merged commit 698aba3 into SoftFever:main Jan 15, 2024
12 checks passed
@igiannakas
Copy link
Contributor Author

Yeah the algorithm didn’t filter them out. It’s an edge case hence why it has not been discovered before

@igiannakas igiannakas deleted the 3603-retractions-in-vase-mode-when-travel-distance-threshold-is-set-to-0 branch January 17, 2024 08:01
SoftFever pushed a commit that referenced this pull request Feb 14, 2024
…ct travel threshold is set to 0 (#3614)

Fixes retraction on layer change being performed when retract travel threshold is set to 0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retractions in vase mode when Travel distance threshold set to 0
2 participants