Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug fix] Fixes "Wipe before external loop" causing blobs on single wall perimeters #3616

Conversation

igiannakas
Copy link
Contributor

@igiannakas igiannakas commented Jan 11, 2024

Fixes #3450

Introduced a check to ensure that a neighbouring internal perimeter exists at the deretraction point when wipe before external loop is enabled. This avoids a situation where the de-retraction is done partly in mid-air, causing an external surface zit.

Before:
image

After:
image

Regular use case is unaffected.

image

@igiannakas igiannakas changed the title Fixes #3603 - "Wipe before external loop" causing blobs on single wall perimeters Fixes #3450 - "Wipe before external loop" causing blobs on single wall perimeters Jan 11, 2024
@igiannakas igiannakas changed the title Fixes #3450 - "Wipe before external loop" causing blobs on single wall perimeters [Bug fix] Fixes "Wipe before external loop" causing blobs on single wall perimeters Jan 12, 2024
…xternal-loop-causing-blobs-on-single-perimeter-walls
…xternal-loop-causing-blobs-on-single-perimeter-walls
…xternal-loop-causing-blobs-on-single-perimeter-walls
src/libslic3r/GCode.hpp Outdated Show resolved Hide resolved
src/libslic3r/GCode.hpp Outdated Show resolved Hide resolved
Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good!

@SoftFever
Copy link
Owner

Thanks!

@SoftFever SoftFever merged commit c0c05c7 into SoftFever:main Jan 18, 2024
12 checks passed
@igiannakas igiannakas deleted the Fix-#3603---Wipe-before-external-loop-causing-blobs-on-single-perimeter-walls branch January 18, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Wipe before external loop" causing blobs on single wall perimeters
2 participants