New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flatpak build #4175
base: main
Are you sure you want to change the base?
Flatpak build #4175
Conversation
Flatpak build is ready, but I need to fix CI and add a CI job for flatpak. |
@powpingdone it looks like github CI VM doesn't get enough free disk space to build a flatpak. Maybe it's time to ask help from flatpak experts? |
I'm trying one last thing before that. |
@SoftFever could you please approve the workflow so I can continue testing? |
It should build automatically now. I temporarily disabled CI/CD this morning as I was fixing a build error. Let me know if it still has issues. |
Alright, @SoftFever . It's ready. Took way too damn long but it's ready for review and merging. From here, because of the unique setup, after this is merged (and begins building bundles) I'll get in contact with the Flathub admins so that automated upload keys can be given. You'll be given a secret API key which will be used in the CI. |
Looking at the changes within this PR I'd suggest to split it into several phases:
That'll make review of the changes and validation easier |
@powpingdone |
Should the included images be updated for the redesign that yw4z made and some other changes that were added? |
@cochcoder What updated design? The cube navigator? |
The #4368 was a redesign of all of the icons in Orca Slicer while #5239 changed the color scheme in some areas (G-Code viewer, Bed plate, etc.). |
Ah, I had not noticed. Oops. Anyways, up to Softfever. |
I'm testing out the artifact generated above. Can slice and send to a Bambu printer without issue! A few issues exist that are probably unrelated to the Flatpak itself, such as being unable to preview an X1 camera feed due to the "system player missing", which I've seen as a general Linux issue. |
Just grabbed the flatpak myself to test and was able to replicate. My X1C camera works under Bambu Studio's flatpak but not under this one. Using x1plus 1.1 in LAN mode. Everything else seems to work fine though. There a way for me to provide some helpful logs? STDOUT and the log dir in I wouldn't consider this a blocker for merging though. Could always iron out this particular bug later. |
@powpingdone |
They are required to make the Flatpak (CI) work, mostly because of size constraints and for installing into |
@SoftFever The CMake changes can be put into a list:
|
@Alaric323 @rehashedsalt unfortunately I don't have any bambu lab printer to test with so once this is merged, I'll need some help debugging this particular dep issue |
This is here so that I can link #3949 and #1670, along with testing the CI. THIS IS NOT FINISHED, AT ALL.
(imho it's really hard to find external work to show what's going on in an issue so I'm linking it here)