Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dremel 3D20, 3D40, and 3D45 #4777

Merged
merged 47 commits into from
May 19, 2024
Merged

Add Dremel 3D20, 3D40, and 3D45 #4777

merged 47 commits into from
May 19, 2024

Conversation

cochcoder
Copy link
Contributor

@cochcoder cochcoder commented Mar 30, 2024

In this PR I added the profiles based as close to the ones in Dremel's slicer, DigiLab, however, a few QOL settings were added, such as combine infill and Arachne mode. One main concern I have is the start/end G-Codes as I copied them word for word from DigiLab, but I don't know if they will work as intended in Orca Slicer. I think that these printers will make a great addition to Orca Slicer as I only found them in DigiLab and Simplify3D, which DigiLab, in my experience, is based on a very old slicer (if not version), has a very limited feature set, and loves to freeze up and die.

This PR is marked as a draft as the TO-DO list needs to be completed:

  • Fix bug where printers are not applied when added *I need help with this one!
  • Add bed models
  • Add bed textures

Test the profiles and make any needed improvements:

  • Dremel 3D20
  • Dremel 3D40
  • Dremel 3D45

Fixes #1423

@tuvinez
Copy link

tuvinez commented Apr 13, 2024

any dates for working profile of dremel printers for OrcaSlicer?

@cochcoder
Copy link
Contributor Author

any dates for working profile of dremel printers for OrcaSlicer?

Not currently, I opened this as a draft due to a couple of reasons and has a low priority. Some of the main reasons this is a draft is that the profiles won't apply when selected (I need help on fixing this) and testing is needed as I don't personally own these machines but see a need for them to be included.

@cochcoder
Copy link
Contributor Author

or it's not listed in Dremel.json

It seems that reordering it, so that fdm_process_common is listed before fdm_process_dremel_common, has fixed it.

@cochcoder
Copy link
Contributor Author

cochcoder commented Apr 22, 2024

@SoftFever It's still having the issue where the profiles don't show up even when the printers are selected. I am trying to see if having one build plate model for two printers is the issue.

EDIT: This did not fix the issue

@cochcoder
Copy link
Contributor Author

UPDATE: Not sure what happened, but I decided to try building it again and the processes show up now after restarting the application and seem to work.

If anyone can test these profiles and make sure that they work as intended, that would be awesome!

@cochcoder cochcoder mentioned this pull request Apr 30, 2024
@SoftFever SoftFever marked this pull request as ready for review May 19, 2024 06:08
Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
I fixed an issue that it won't load on Mac/Linux OS
It looks fine now.

@SoftFever SoftFever merged commit 9467aa2 into SoftFever:main May 19, 2024
1 check passed
@cochcoder
Copy link
Contributor Author

@SoftFever I'm not sure about merging this PR quite yet as I have no clue if these machines will work without testing

@cochcoder cochcoder deleted the dremel branch May 29, 2024 13:44
@eduncan911
Copy link

eduncan911 commented May 31, 2024

Hello everyone and @SoftFever !

Eric Duncan here, (semi-new) Lead Firmware Engineer for all Dremel Printers. :-)

This was an excellent submission. I apologize I didn't catch it in the PRs, as I have been actively developing on Orca for several months now - actually creating modules and tuned profiles to release so we can support our customers with hardened battle-tested profiles.

Kind of surprised this slipped past me. I've been in the issues and PRs here, merging code for a while. Sorry again!


Now the question is, what do we do with these base submissions here?

@SoftFever Does Dremel have a right to override them here?

I do not want to do that because that would be against the spirit of the author's (@cochcoder) hard work they put into this PR. And personally, coming from open source myself, I do not want to do that.

However, all of my Orca resources files are vastly different than this PR though. It's due to the Bambu limitations to profiles they did here to their branch, compared to Prusa branches and all other slicers. Read: I have like 90 new files to submit because of all the duplication required for the filtering of all conditions in the Bambu-version of profiles, across all the filament types and filters. It's still a WIP at this time though across other slicers and priorities, but I could open a PR soon.

Dremel, company-wise, they have to be able to support customers with known good profiles.

So I am not sure about releasing this version of the Dremel profiles as "base" profiles at this time to end-users, as we all know how "modifying" a Built-In Printer automatically copies the base profile to user profiles, like for a simple WiFi IP address!! Argh.

And because of that "feature" of copying built-in profiles to user profiles in these slicers, we would never be able to update those users again to corrected profiles without causing more customer service calls and knowledge base articles to address how to purge an old vendor list for a new vendor list.

@eduncan911
Copy link

eduncan911 commented May 31, 2024

I've also been told I'm vastly over-thinking this, and to just submit all the updates asap. However, the timeline doesn't match up for this beta 2.1.0 release. Hence, why I am getting in front of this and have to serious apologize for not catching it earlier.

@cochcoder
Copy link
Contributor Author

@eduncan911 Thank you for your response, I would be open to removing the 3D20 & 3D40 profiles as I haven't had anyone test those yet. However for the 3D45, I currently have a PR that is fixing all of the issues with it being able to print. I think that one should be left, if it works as expected after the PR, until the battle-hardened one is ready. Unless you think that the profiles will be ready before the main 2.1 release (which would be in around 18 days if it follows the same schedule of the 2.0 release). I ultimately leave this up to @SoftFever though.

@cochcoder
Copy link
Contributor Author

cochcoder commented Jun 1, 2024

I can rename the current profiles to what the names are for the profiles that are being worked on. So that when the profiles will be seamlessly merged and only the values would change for the end user, without breaking any custom profiles they may have already made.

@cochcoder
Copy link
Contributor Author

cochcoder commented Jun 6, 2024

@eduncan911 Around what time should we expect a PR to add these printers if they were removed for the time being? Which models would be supported?

@SoftFever
Copy link
Owner

Hello everyone and @SoftFever !

Eric Duncan here, (semi-new) Lead Firmware Engineer for all Dremel Printers. :-)

This was an excellent submission. I apologize I didn't catch it in the PRs, as I have been actively developing on Orca for several months now - actually creating modules and tuned profiles to release so we can support our customers with hardened battle-tested profiles.

Kind of surprised this slipped past me. I've been in the issues and PRs here, merging code for a while. Sorry again!

Now the question is, what do we do with these base submissions here?

@SoftFever Does Dremel have a right to override them here?

I do not want to do that because that would be against the spirit of the author's (@cochcoder) hard work they put into this PR. And personally, coming from open source myself, I do not want to do that.

However, all of my Orca resources files are vastly different than this PR though. It's due to the Bambu limitations to profiles they did here to their branch, compared to Prusa branches and all other slicers. Read: I have like 90 new files to submit because of all the duplication required for the filtering of all conditions in the Bambu-version of profiles, across all the filament types and filters. It's still a WIP at this time though across other slicers and priorities, but I could open a PR soon.

Dremel, company-wise, they have to be able to support customers with known good profiles.

So I am not sure about releasing this version of the Dremel profiles as "base" profiles at this time to end-users, as we all know how "modifying" a Built-In Printer automatically copies the base profile to user profiles, like for a simple WiFi IP address!! Argh.

And because of that "feature" of copying built-in profiles to user profiles in these slicers, we would never be able to update those users again to corrected profiles without causing more customer service calls and knowledge base articles to address how to purge an old vendor list for a new vendor list.

Hi @eduncan911 @cochcoder

Sorry, I overlooked the message here.
Since the changes in this PR are not yet included in the official 2.1.0 release, it's fine to rename or change or delete files. It would be tricky if the profiles were widely adopted by users because renaming or deleting profiles would prevent loading user's custom settings.
However, that is not the case here. Feel free to submit your changes via a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dremel 3D45 support
4 participants