Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/merge bs1.91 #5394

Merged
merged 38 commits into from
May 19, 2024
Merged

Feature/merge bs1.91 #5394

merged 38 commits into from
May 19, 2024

Conversation

SoftFever
Copy link
Owner

Description

Screenshots/Recordings/Graphs

Tests

afriede and others added 30 commits May 19, 2024 10:23
@afriede @SoftFever
fixed logic error in PLA jamming gcode for P1S
04b51e7
@SoftFever
Fix use after free bug in LinesBucketQueue::emplace_back_bucket
5c4e0bd 
I found a use after free bug in LinesBucketQueue::emplace_back_bucket. This was found by enabling address sanitizer.
The LinesBucketQueue class has two related members:
std::vector<LinesBucket> line_buckets;
std::priority_queue<LinesBucket *, std::vector<LinesBucket *>, LinesBucketPtrComp> line_bucket_ptr_queue;
line_bucket_ptr_queue holds pointers into line_buckets. However, since items are inserted into line_buckets one at a time, existing pointers that were stored inside line_bucket_ptr_queue become invalid. Specifically:
void LinesBucketQueue::emplace_back_bucket(ExtrusionLayers &&els, const void *objPtr, Point offset)
{
    auto oldSize = line_buckets.capacity();
    line_buckets.emplace_back(std::move(els), objPtr, offset); <--- Causes a reallocation, making previous pointers invalid
    line_bucket_ptr_queue.push(&line_buckets.back()); <-- priority queue compares against old, now invalid pointers
    ...

The proposed fix is to calculate the required number of entries in ConflictChecker::find_inter_of_lines_in_diff_objs, and then calling line_buckets.reserve(count). This ensures that sufficient buffer is allocated up front and the pointers are stable as items are added.
@SoftFever
Updated to fix the handling of the capacity change, and removed the c…
69695fe 
…ode I previously added to reserve upfront since it is not really needed
@SoftFever
Remove accidentally added whitespace
bfce63c
@SoftFever
Removed unused method
87e9807
@Haidiye00 @SoftFever
ENH:add mz_zip_reader_extract_to_file_w api
52476a8 
to solove plugin install failed problem by special wide char
jira: none
Change-Id: Ic7d3efe3fdf852387650abf9df65803da9e46a60
(cherry picked from commit b68ad03717a63675fef2f3ef73d4058bf311adea)
@bambu123 @SoftFever
FIX: PrinterFileSystem report real connect error
1063482 
Change-Id: I99d6ff7f6dcb1f53ccf59854f5f19d0bd39fa9fc
Jira: none
@DanBao-Bambu @SoftFever
rename preference name
56abf75
@Haidiye00 @SoftFever
FIX:Relax restrictions on importing obj files
549f722 
jira: none
Change-Id: I61a0156a8424a5f59922956918d37d38e2c3306a
@DanBao-Bambu @SoftFever
FIX: [6469] popup dialog too mach when reload object
30e9ea3 
Jira: 6469

Change-Id: I4097e3a3b018c7a676fea93bf63f8f778bb3148b
@walterwongbbl @SoftFever
FIX:fixed incorrect display of printer options page on Linux
153a407 
jira:[STUDIO-6220]

Change-Id: Id1f084658b0b340b7f17ab97ba82c0fd3ae83fae
@ArthurBambulab @SoftFever
FIX: handle exception of dividing by zero in arranging
278aaaf 
jira: none
Change-Id: I0d20464dbe81a80293539100f06d72dee456a27b
(cherry picked from commit 94746ae9bf7f467243849570450567b4fdc78e3a)
@Haidiye00 @SoftFever
ENH:delete no use code
a6ff515 
jira: none
Change-Id: I40e7ffa7ea47bb3cd4039eef9f6c28c604eb3abc
@bambu123 @SoftFever
FIX: PrinterFileSystem::FileRemoved
3638ab3 
Change-Id: I891aaa8d58ff379dc1ebd8581064865a33388f74
@bambu123 @SoftFever
FIX: resend ttcode to printer on -90 error
780d92a 
Change-Id: I96dc45102a2759a9f1a0002f42c3a91b2c6b2d75
Jira: STUDIO-5947
(cherry picked from commit 97d687b7c88f8cd51b8eddd39120349d8eac42b1)
@MklBambu @SoftFever
FIX: fix some issue in multi machine
c18126a 
JIRA: STUDIO-6934 STUDIO-6888
1. Fix the issue of incomplete display caused by excessively long file names
2. Fix the issue of icon display being too large
3. Fix the issue of garbled Chinese characters in the task list

Change-Id: I36bc10bf2067f44aaa7e3651b58e526ea323c8ad
@MklBambu @SoftFever
FIX: Incorrect multiplier, when the multiplier is set to below 1
6f2089f 
github: #3987 #3805
1. In some languages that use commas as decimal points, setting multiplier below 1 will resolve to 0
2. Unable to save multiplier correctly

Change-Id: I62bc55e270929ebb5e910eb79c6f97106e842b93
@SoftFever
Arrange
2487e50
@XunZhangBambu @SoftFever
FIX: wrong wipe tower when open 3mf file
9265a58 
1.wipe tower pos in 3mf was overwritten by default pos when opening 3mf
with a different printer profile.This patch fix it

jira: STUDIO-5890

Signed-off-by: xun.zhang <xun.zhang@bambulab.com>
Change-Id: I12e5d4b80a0ad86194db0682c1763ba4a9492521
@XunZhangBambu @SoftFever
ENH: update A1 machine gcode
9e06fc1 
1.Adjust the y position of the A1 extrusion compensation line

jira:NEW

Signed-off-by: xun.zhang <xun.zhang@bambulab.com>
Change-Id: Iea690a0184ae10a47f53e1532272c31fc0a04cfa
@XunZhangBambu @SoftFever
FIX: minor spelling mistake in gcode
c614b90 
github:#3477

Signed-off-by: xun.zhang <xun.zhang@bambulab.com>
Change-Id: Id3201bf8b8125ce060e2cac102ab2525877e27c1
@zhimin-zeng-bambulab @SoftFever
FIX: slice crash with height_range
bc44a74 
github: 3917
Change-Id: Icdf83013213b47935b7a795ed75cc3d49057665d
@bambu123 @SoftFever
FIX: ERROR_RES_BUSY text
10652e1 
Change-Id: Ifde1a7b0c6ab915eb226c2072c46edd40f60cf9a
Jira: STUDIO-6436
@walterwongbbl @SoftFever
ENH:Unable to send printing without selecting a device
4887c99 
jira:[STUDIO-6850]

Change-Id: Ic537579727fd1618af364db93fce8fbbe4cd635a
@Haidiye00 @SoftFever
FIX:add exit_gizmo before slice model
b9caddb 
jira: STUDIO-5531
Change-Id: Icddc9d73b3d91bb68e9768d13e48cbae0680e58e
@bambu123 @SoftFever
FIX: PrinterFileSystem report real connect error
4c75a37 
Change-Id: Id6750cfa2a98fe8325ba677dabb606a0a701b495
@LiZ-Li-BBL @SoftFever
FIX: add can slice judgement in slice all plates processing
3e72398 
jira: STUDIO-6325

Change-Id: Ic7fb8cef000c03210bb77289a570ee6b60b6083e
@walterwongbbl @SoftFever
FIX:Fixed error in displaying the name of Bambu filaments
10c607c 
Change-Id: Ib42194c07b6eefe793eec81a588debc9d622d951
@LiZ-Li-BBL @SoftFever
FIX: text hidden in calibration tab
8fd6ba5 
jira: STUDIO-6264

Change-Id: I24fbc590638a3213d948a973422e010486113923
@XunZhangBambu @SoftFever
FIX: logic error in PLA fan control
c9dae86 
github PR: #3948

Signed-off-by: xun.zhang <xun.zhang@bambulab.com>
Change-Id: I28e4a673e590e83d151e92cc82caab45012aeabe
Haidiye00 and others added 8 commits May 19, 2024 12:20
@Haidiye00 @SoftFever
FIX:upgrade cluster algorithm to remove duplicate labels
cbe4491 
jira: none
Change-Id: I4d68d8cd8e080932c7c308bc8f69e27546ffe309
@LiZ-Li-BBL @SoftFever
FIX: can not parse json float in ES on macOS
4047d17 
jira: STUDIO-5889

Change-Id: I622f4b474c378d77b0e43d67a320f023be2d5811
@walterwongbbl @SoftFever
ENH:Clear the value of the previous nozzle type
f0bd067 
jira:[for nozzle check]

Change-Id: I9a932b833fb07de6cb0a91abe6372b0e91f273f1
@XunZhangBambu @SoftFever
ENH: update A1 gcode
bf69d0b 
1.Modify the width of extrusion compensation line

jira:NEW

Signed-off-by: xun.zhang <xun.zhang@bambulab.com>
Change-Id: I90543758c866d74f2154e3135d7569109def84b8
@zhimin-zeng-bambulab @SoftFever
FIX: the height range is not valid in assemble object
31f06a2 
github: 3876
Change-Id: Id38672bbf0c01bc9b9f0a3e2bf1052d945b45131
@LiZ-Li-BBL @SoftFever
FIX: calibration page text hidden in linux
93cef93 
jira: STUDIO-6264

Change-Id: If210abf64057eb2e9c2c5b11d41fa33f18684c72
@walterwongbbl @SoftFever
ENH:clear nozzle information
bbb41da 
jira:[STUDIO-7050]

Change-Id: I15ca4973d09132ddb5cb5a56bedd795ba6976b27
@SoftFever
update plugin version
25e1036
@SoftFever SoftFever merged commit ad341ec into main May 19, 2024
13 checks passed
@SoftFever SoftFever deleted the feature/merge_bs1.91 branch May 19, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet