Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix slow_down_layers #5396

Merged
merged 1 commit into from
May 24, 2024
Merged

Conversation

buzzhuzz
Copy link
Contributor

Description

Setting slow_down_layers to 2 or more results in wrong number of slowed down layers.

Do not increment layer_id since bottom layer (#0) handled separately.

At slow_down_layers=0 and slow_down_layers=1 acts the same slowing down first layer.
Values slow_down_layers >= 2 defines exact number of layers printed at slower speeds.

Addresses #4898

Tests

Manual tests. Test gcode with different slow_down_layers values attached:
slow_down_layers-test.zip

Setting slow_down_layers to 2 or more results in wrong number of slowed
down layers.

Do not increment layer_id since bottom layer (#0) handled separately.
@igiannakas
Copy link
Contributor

Nice one!

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SoftFever
Copy link
Owner

Thanks.
This should reduce the confusion, hehe

@SoftFever SoftFever merged commit 966c18c into SoftFever:main May 24, 2024
12 checks passed
@buzzhuzz buzzhuzz deleted the dbuzz/slow_down_layers branch May 24, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants