Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

05-24 filenaming and some fixes #5444

Closed
wants to merge 0 commits into from
Closed

Conversation

Bai825
Copy link
Contributor

@Bai825 Bai825 commented May 24, 2024

Description

  1. Removed the Generic in filament naming.
  2. Add the "@ff" format in filament naming.
  3. Updated the gcode start command: E-0.2.
  4. Fix the filament type for FusRock S-Multi and FusRock S-PAHT.

Screenshots/Recordings/Graphs

See changed files in the commit.

Tests

Worked on local OrcaSlicer portable package.

@SoftFever For your review.

@SoftFever
Copy link
Owner

Can you check and fix the errors reported by the "Check profiles"?

@Bai825
Copy link
Contributor Author

Bai825 commented May 27, 2024

Can you check and fix the errors reported by the "Check profiles"?

Yes, this error occurred before.

@RikshaDriver I seemed not be able to locate the issues from the prompt. I also fixed the naming for AD3 machine profile. Can you help me check on the below prompt and is there any other method I can debug locally before making a PR?
check_profile1

@RikshaDriver
Copy link
Contributor

The test is referencing the old "Generic" filaments.

@SoftFever does the check script require manual updating if filaments have been removed/renamed?

@SoftFever
Copy link
Owner

It is not suppose to rename/delete existing profiles as it will invalidate users' custom profile based them.

@RikshaDriver
Copy link
Contributor

It is not suppose to rename/delete existing profiles as it will invalidate users' custom profile based them.

@SoftFever @Bai825 it may be worthwhile looking at developing a "profile migration" tool if filament/nozzle profile renaming is required.

@Bai825
Copy link
Contributor Author

Bai825 commented Jun 12, 2024

It is not suppose to rename/delete existing profiles as it will invalidate users' custom profile based them.

I see. Guess I will continue with the old naming style for now. Will try to make another PR with the existing naming later. Thanks!

@Bai825
Copy link
Contributor Author

Bai825 commented Jun 12, 2024

It is not suppose to rename/delete existing profiles as it will invalidate users' custom profile based them.

@SoftFever @Bai825 it may be worthwhile looking at developing a "profile migration" tool if filament/nozzle profile renaming is required.

Agree, that will help with situations when one wants to make things cleaner if there are too many profiles in different naming rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants