feat: [no-issue] upgrade to v1020 of Web SDK and migrate to ng cli

[reey]

Proposed changes

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
• Documentation Update (if none of the other choices apply)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist

• I have read the CONTRIBUTING doc
• I have signed the CLA (in all commits with git commit -s)
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

Further comments

[jdreSAG]

currently there is an issue with tests. I guess all of them might have one origin, as most of them which are failing are time-related.
one of them, a little bit modified for debugging:

it.only('should return resolved data', fakeAsync(() => {
  // when
  const values = { [new Date().toString()]: [{ min: 0, max: 1 }] };
  (global as any).fetch = jest.fn().mockImplementationOnce(() =>
    Promise.resolve({
      json: () => ({ values } as ISeries),
    })
  );
  console.log('before sub', new Date().toISOString())
  let resolvedData;
  service.listSeries$({} as any).subscribe((val) => {
    console.log('sub callback', new Date().toISOString());
    resolvedData = val.data;
  });
  tick(1000);
  console.log('after tick', new Date().toISOString());

  // then
  expect(resolvedData.values).toEqual(values);
}));

and order of console.logs is:

-console.log
before sub 2024-06-05T10:44:30.924Z
-console.log
after tick 2024-06-05T10:44:31.924Z
-console.log
sub callback 2024-06-05T10:44:30.991Z

So dates are looking fine, 'after tick' is called 1000ms after 'before sub'. and 'sub callback' date is between them (which is ok), but order should be

• before sub
• sub callback
• after tick

expect is called after 'after tick' but before 'sub callback' so it's still undefined. flush does not work. fixture.detectChanges is not a case, there is no fixture, this is service test suite. and I don;t really want to switch to waitForAsync, other test cases (much more complicated and time related) are also failing. I tried with async and used await approach by converting observable to Promise and it worked.

[jdreSAG]

currently there is an issue with tests. I guess all of them might have one origin, as most of them which are failing are time-related. one of them, a little bit modified for debugging:

it.only('should return resolved data', fakeAsync(() => {
  // when
  const values = { [new Date().toString()]: [{ min: 0, max: 1 }] };
  (global as any).fetch = jest.fn().mockImplementationOnce(() =>
    Promise.resolve({
      json: () => ({ values } as ISeries),
    })
  );
  console.log('before sub', new Date().toISOString())
  let resolvedData;
  service.listSeries$({} as any).subscribe((val) => {
    console.log('sub callback', new Date().toISOString());
    resolvedData = val.data;
  });
  tick(1000);
  console.log('after tick', new Date().toISOString());

  // then
  expect(resolvedData.values).toEqual(values);
}));

and order of console.logs is:

-console.log before sub 2024-06-05T10:44:30.924Z -console.log after tick 2024-06-05T10:44:31.924Z -console.log sub callback 2024-06-05T10:44:30.991Z

So dates are looking fine, 'after tick' is called 1000ms after 'before sub'. and 'sub callback' date is between them (which is ok), but order should be

• before sub
• sub callback
• after tick

expect is called after 'after tick' but before 'sub callback' so it's still undefined. flush does not work. fixture.detectChanges is not a case, there is no fixture, this is service test suite. and I don;t really want to switch to waitForAsync, other test cases (much more complicated and time related) are also failing. I tried with async and used await approach by converting observable to Promise and it worked.

issue fixed.