-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MTM-52605] Configure alarms and events in Data points graph 2.0 and display on chart #29
Open
jdreSAG
wants to merge
51
commits into
main
Choose a base branch
from
feat/MTM-52605-alarm-and-event-in-data-points-graph-2
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[MTM-52605] Configure alarms and events in Data points graph 2.0 and display on chart #29
jdreSAG
wants to merge
51
commits into
main
from
feat/MTM-52605-alarm-and-event-in-data-points-graph-2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alarm selector module and list component n/a
Alarm selector list item component added n/a
Alarm selector list item color pick and display label n/a
Alarm selector list item change active property and save n/a
Alarm selector list item remove item n/a
Alarm selector list item attributes form- label and data type n/a
Alarm selector list item attributes form- type property form n/a
Alarm selector list item attributes form- refactor n/a
Alarm selector list refactor n/a
Alarm selector modal component added n/a
Alarm selector component- asset selector column n/a
Alarm selector component- provide context asset n/a
Alarm selector component- get alarms for asset n/a
Alarm selector component- allow to add custom alarm n/a
Alarm selector component- selected alarms column n/a
Alarm attributes form component- adding alarm timelineType n/a
Alarm selector component- refactor n/a
Alarm attributes form component- select severities n/a
Alarm selector component- blank alarm select severities n/a
Alarm selector allows to be used as event selector n/a
Alarm selector allows to be used as event selector n/a
Alarm event attributes refactor n/a
Alarm event selector refactor n/a
Alarm event selector service unit tests n/a
Alarm event attributes form unit tests n/a
Alarm event selection list unit tests n/a
Redundant isValid$ removed n/a
includes alarm pipe unit tests n/a
Alarm event selector unit tests n/a
ExpressionChangedAfterItHasBeenCheckedError error fix n/a
Initial commit n/a
…into feat/MTM-58883-alarm-and-event-selector
Hide attributes form on alarm event selector modal n/a
Alarm event selector rename search to filter n/a
Refactor way how custom alarm or event is added n/a
Remove severity selection for alarms n/a
Show warning that list contains only recent alarms and events n/a
9 tasks
Default color for custom alarm or event n/a
Label as required; clear form on add. n/a
Remove redundant code n/a
Reset form after adding custom item n/a
Reset form after adding custom item refactor. n/a
Unit tests added for alarm event attributes form. Other unit tests fixes. n/a
Destroy attribute form to get initial state. n/a
Refactor of translate pipe in template. Refactor fo includes pipe transform method. n/a
…-selector feat(datapoints-graph): alarm event selector list for Data points graph 2.0
add lodash package and types for it. fix types issue. n/a
Disable color picker on modal selector list n/a
Create shared styling for view and config to always load needed styling n/a
…s and alarms (#28) Signed-off-by: Enio Sultan <92023325+eniosultan@users.noreply.github.com> Co-authored-by: Enio Sultan <enio94.sutan@gmail.com> Co-authored-by: enio_sultan <ensu@softwareag.com> Co-authored-by: Carlos Ceia <carlosceia@gmail.com> Co-authored-by: jdreSAG <103751383+jdreSAG@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just an integration branch for PRs:
#27 - selector- merged
#28 - displaying alars/events on chart- merged
TO DO:
To QA: test alarm/event selector in context of home dashboard, groupd dashboard and device dashboard
n/a
Proposed changes
As a user, I should be able to select alarms and events from particular assets and display them on chart.
Types of changes
Paste Link to the issue
Checklist
Further comments