Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MTM-52605] Configure alarms and events in Data points graph 2.0 and display on chart #29

Open
wants to merge 51 commits into
base: main
Choose a base branch
from

Conversation

jdreSAG
Copy link
Collaborator

@jdreSAG jdreSAG commented May 10, 2024

This is just an integration branch for PRs:
#27 - selector- merged
#28 - displaying alars/events on chart- merged

TO DO:

  • Fix alarm/event icon coords when between 2 datapoints.
  • Show alarms/events in preview, currently the issue is that the config object has the wrong properties

To QA: test alarm/event selector in context of home dashboard, groupd dashboard and device dashboard
n/a

Proposed changes

As a user, I should be able to select alarms and events from particular assets and display them on chart.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Alarm selector module and list component

n/a
Alarm selector list item component added

n/a
Alarm selector list item color pick and display label

n/a
Alarm selector list item change active property and save

n/a
Alarm selector list item remove item

n/a
Alarm selector list item attributes form- label and data type

n/a
Alarm selector list item attributes form- type property form

n/a
Alarm selector list item attributes form- refactor

n/a
Alarm selector modal component added

n/a
Alarm selector component- asset selector column

n/a
Alarm selector component- provide context asset

n/a
Alarm selector component- get alarms for asset

n/a
Alarm selector component- allow to add custom alarm

n/a
Alarm selector component- selected alarms column

n/a
Alarm attributes form component- adding alarm timelineType

n/a
Alarm selector component- refactor

n/a
Alarm attributes form component- select severities

n/a
Alarm selector component- blank alarm select severities

n/a
Alarm selector allows to be used as event selector

n/a
Alarm selector allows to be used as event selector

n/a
Alarm event attributes refactor

n/a
Alarm event selector refactor

n/a
Alarm event selector service unit tests

n/a
Alarm event attributes form unit tests

n/a
Alarm event selection list unit tests

n/a
Alarm event selector unit tests

n/a
ExpressionChangedAfterItHasBeenCheckedError error fix

n/a
…into feat/MTM-58883-alarm-and-event-selector
Hide attributes form on alarm event selector modal

n/a
Alarm event selector rename search to filter

n/a
Refactor way how custom alarm or event is added

n/a
Remove severity selection for alarms

n/a
Show warning that list contains only recent alarms and events

n/a
carlosceia and others added 10 commits May 21, 2024 10:56
Default color for custom alarm or event

n/a
Label as required; clear form on add.

n/a
Reset form after adding custom item

n/a
Reset form after adding custom item refactor.

n/a
Unit tests added for alarm event attributes form. Other unit tests fixes.

n/a
Destroy attribute form to get initial state.

n/a
Refactor of translate pipe in template. Refactor fo includes pipe transform method.

n/a
…-selector

feat(datapoints-graph): alarm event selector list for Data points graph 2.0
@jdreSAG jdreSAG marked this pull request as ready for review June 3, 2024 10:15
jdreSAG and others added 4 commits June 3, 2024 14:53
add lodash package and types for it. fix types issue.

n/a
Disable color picker on modal selector list

n/a
Create shared styling for view and config to always load needed styling

n/a
…s and alarms (#28)

Signed-off-by: Enio Sultan <92023325+eniosultan@users.noreply.github.com>
Co-authored-by: Enio Sultan <enio94.sutan@gmail.com>
Co-authored-by: enio_sultan <ensu@softwareag.com>
Co-authored-by: Carlos Ceia <carlosceia@gmail.com>
Co-authored-by: jdreSAG <103751383+jdreSAG@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants