chore: update pylint and linting (#104)

.pylintrc

@@ -486,4 +486,4 @@ allow-any-import-level=
 
 # Exceptions that will emit a warning when being caught. Defaults to
 # "Exception"
-overgeneral-exceptions=Exception
+overgeneral-exceptions=builtins.Exception

c8ylp/cli/core.py

@@ -534,11 +534,11 @@ def run_proxy_in_background(
     background = threading.Thread(
         target=start_proxy,
         args=(ctx, opts),
-        kwargs=dict(
-            connection_data=connection_data,
-            stop_signal=stop_signal,
-            ready_signal=_local_ready_signal,
-        ),
+        kwargs={
+            "connection_data": connection_data,
+            "stop_signal": stop_signal,
+            "ready_signal": _local_ready_signal,
+        },
         daemon=True,
     )
     background.start()

c8ylp/cli/plugin.py

@@ -32,6 +32,10 @@
 from .core import ExitCodes, ProxyContext
 
 
+class CommandNotFound(Exception):
+    """Command not found"""
+
+
 def plugin_folders() -> List[Path]:
     """Plugin folders
 
@@ -113,7 +117,7 @@ def build_cmd_args(cmd_args: List[str]) -> List[str]:
             return out_args
 
         if not shutil.which(custom_shell):
-            raise Exception(f"Could not find {custom_shell}")
+            raise CommandNotFound(f"Could not find {custom_shell}")
 
         return [shutil.which(custom_shell)] + out_args
 
@@ -288,9 +292,9 @@ def cli_plugin():
     cls=PluginCLI,
     hidden=False,
     options_metavar="",
-    context_settings=dict(
-        ignore_unknown_options=True,
-    ),
+    context_settings={
+        "ignore_unknown_options": True,
+    },
 )
 def run():
     """

c8ylp/helper.py

@@ -90,7 +90,7 @@ def get_unused_port() -> int:
         return sock.getsockname()[1]
 
 
-CONTEXT_SETTINGS = dict(help_option_names=["-h", "--help"])
+CONTEXT_SETTINGS = {"help_option_names": ["-h", "--help"]}
 
 
 @click.group(context_settings=CONTEXT_SETTINGS)

c8ylp/main.py

@@ -25,7 +25,7 @@
 from .cli.version import version
 from .cli.connect import commands as connect
 
-CONTEXT_SETTINGS = dict(help_option_names=["-h", "--help"])
+CONTEXT_SETTINGS = {"help_option_names": ["-h", "--help"]}
 
 
 @click.group()

c8ylp/rest_client/c8yclient.py

@@ -44,6 +44,10 @@
 from c8ylp.rest_client.sessions import BaseUrlSession
 
 
+class CumulocityError(Exception):
+    """Cumulocity error"""
+
+
 class CumulocityMissingTFAToken(Exception):
     """Cumulocity missing TFA token"""
 
@@ -359,7 +363,7 @@ def get_managed_object(
         mor_id = ext_id.get("managedObject", {}).get("id")
 
         if not mor_id:
-            raise Exception("Managed object id is empty")
+            raise CumulocityError("Managed object id is empty")
 
         response = self.session.get(f"/inventory/managedObjects/{mor_id}")
         if response.status_code == 200:

requirements-dev.txt

@@ -2,7 +2,7 @@
 invoke==2.0.0
 
 # Linting/formating
-pylint==2.15.5
+pylint==2.16.0
 black==22.10.0
 licenseheaders==0.8.8