Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MTM-41851 C# REST SDK to be on par with Java #3

Merged
merged 13 commits into from
Nov 8, 2021
Merged

MTM-41851 C# REST SDK to be on par with Java #3

merged 13 commits into from
Nov 8, 2021

Conversation

ashhSAG93
Copy link
Contributor

@ashhSAG93 ashhSAG93 commented Oct 25, 2021 •
edited

MTM-41851 C# REST SDK to be on par with Java

@ashhSAG93 ashhSAG93 changed the title C# REST SDK to be on par with Java MTM-41851 C# REST SDK to be on par with Java Oct 25, 2021
bbyreddy
bbyreddy reviewed Oct 25, 2021
View reviewed changes
Copy link

@bbyreddy bbyreddy left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ashhSAG93,
Based on my understanding of C#, I did review, but we may need a short session together to get more clarity on certain aspects.
A couple of observations

  1. We are in general missing journal logging (both old and new code), which needs to be improved without significantly affecting the performance.
  2. Also, I see you have added many tests, which is very good. But since there are so many changes, it would be easier to generate a code coverage report and implement more tests to cover the missing classes/methods and code lines.

Thanks,
Bhaskar.

miryalarahul
miryalarahul reviewed Nov 8, 2021
View reviewed changes
Copy link

@miryalarahul miryalarahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implement the comments

REST-SDK/src/Cumulocity.SDK.Client/Rest/API/Notification/Transport/MessageExchange.cs Outdated Show resolved Hide resolved
REST-SDK/src/Cumulocity.SDK.Client/Rest/API/Notification/Transport/MessageExchange.cs Outdated Show resolved Hide resolved
REST-SDK/src/Cumulocity.SDK.Client/Rest/API/Notification/Watchers/ConnectionHeartBeatWatcher.cs Outdated Show resolved Hide resolved
REST-SDK/src/Cumulocity.SDK.Client/Rest/API/Notification/Watchers/ConnectionHeartBeatWatcher.cs Outdated Show resolved Hide resolved
.../Rest/Representation/Messaging.Notifications/NotificationSubscriptionFilterRepresentation.cs Show resolved Hide resolved
....SDK.Client/Rest/Representation/Messaging.Notifications/NotificationSubscriptionMediaType.cs Show resolved Hide resolved
REST-SDK/src/Cumulocity.SDK.Client/RestConnector.cs Outdated Show resolved Hide resolved
miryalarahul
miryalarahul approved these changes Nov 8, 2021
View reviewed changes
Copy link

@miryalarahul miryalarahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@ashhSAG93 ashhSAG93 merged commit bf50b7b into master Nov 8, 2021
@ashhSAG93 ashhSAG93 deleted the MTM-41851-Implement-the-identified-gaps-in-C#-REST-SDK-to-make-on-par-with-java-REST-SDK branch November 8, 2021 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbyreddy bbyreddy bbyreddy approved these changes

@miryalarahul miryalarahul miryalarahul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ashhSAG93 @bbyreddy @miryalarahul