Fixed the problem with non numbers primary columns #3
Conversation
|
|
||
| if (!type) { console.warn(`Unhandled type: ${this.column.type}`) } | ||
|
|
||
| return type || 'string' | ||
| return type; |
There was a problem hiding this comment.
I am just thinking if this won't break type checking for strict mode in tsconfig - will have to check it out.
| @@ -41,8 +41,8 @@ export class Resource extends BaseResource { | |||
| return [...Object.values(this.propsObject)] | |||
| } | |||
|
|
|||
| public property(path: string): Property | null { | |||
| return this.propsObject[path] || null | |||
There was a problem hiding this comment.
same here - property should return either BaseProperty or null, When you remove || null it could return undefined and this could break types.
There was a problem hiding this comment.
but I will have to check it out
There was a problem hiding this comment.
In theory, all works fine with undefined and reduce the code complexity, but we can rollback it, for sure!
|
🎉 This PR is included in version 1.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.2.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Currently, if you use a different
PrimaryColumnwith strings (perhaps using the 'uuid' method) the application fails.The problem is because it's trying to move from string to number without taking into consideration if it's a number o string.
I fixed and refactor the method, trying to do it less complex.
I changed also the test/specs to check with uuid
PrimaryGeneratedColumn('uuid')