Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the game wait for the server/client connection #12

Open
Sokom141 opened this issue Nov 7, 2020 · 0 comments · Fixed by #33
Open

Make the game wait for the server/client connection #12

Sokom141 opened this issue Nov 7, 2020 · 0 comments · Fixed by #33
Labels
enhancement New feature or request
Milestone
1.0

Comments

@Sokom141
Copy link
Owner

Sokom141 commented Nov 7, 2020

No description provided.

@Sokom141 Sokom141 added the enhancement New feature or request label Nov 7, 2020
@Sokom141 Sokom141 added this to the 1.0 milestone Nov 7, 2020
Sokom141 added a commit that referenced this issue Nov 13, 2020
@Sokom141
Modified the NetworkConnection to make the Client try for a maximum n…
641e097 
…umber of times before giving up the connection to the server.

Now both the Server and the Client can't play before a connection is made.
General improvements to the gameplay and GUI of GameBoard.

Closes #12
@Sokom141 Sokom141 mentioned this issue Nov 13, 2020
Merged
@Sokom141 Sokom141 linked a pull request Nov 13, 2020 that will close this issue
Codeql CWE 502 #33
Merged
Sokom141 added a commit that referenced this issue Nov 15, 2020
@Sokom141
Codeql CWE 502 (#33)
9feed9f 
* Implemented LookAheadObjectInputStream to resolve vulnerability CWE-502 found by CodeQL (unsafe deserialization)
Now only a strict set of objects can be sent through the ObjectInputStream.

* Modified the NetworkConnection to make the Client try for a maximum number of times before giving up the connection to the server.
Now both the Server and the Client can't play before a connection is made.
General improvements to the gameplay and GUI of GameBoard.

Closes #12

* Update NetworkConnection.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Codeql CWE 502 Sokom141/BattleShip
1 participant
@Sokom141