Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EA Desktop implementation #67

Merged
merged 2 commits into from
Feb 1, 2023
Merged

Fix EA Desktop implementation #67

merged 2 commits into from
Feb 1, 2023

Conversation

Nutzzz
Copy link
Contributor

@Nutzzz Nutzzz commented Jan 30, 2023

Also:

  • Use the proper method to select between 32-bit vs. 64-bit Registry
  • Fix some variable capitalization
  • Upgrade a few NuGet packages

@Nutzzz
Fix EA Desktop implementation
f4d59c6 
Also:
* Use the proper method to select between 32-bit vs. 64-bit Registry
* Fix some variable capitalization
* Upgrade a few NuGet packages
@Nutzzz Nutzzz mentioned this pull request Jan 30, 2023
Closed
@Nutzzz
Update to 1.3.1, add references to Rockstar
c6dde2f 
(I am assuming Rockstar is working; I don't own any of their games.)
@Solaire Solaire merged commit 0672d69 into Solaire:master Feb 1, 2023
Nutzzz added a commit to Nutzzz/GLC that referenced this pull request Feb 8, 2024
@Nutzzz
Squashed commit of the following:
1407532 
commit 68b1dde
Author: Nutzzz <enussbaum@hotmail.com>
Date:   Sun Feb 19 15:30:03 2023 -0800

    Add dependency and reference to PureOrigin.API subtree

commit 2d32e78
Author: Nutzzz <enussbaum@hotmail.com>
Date:   Sun Feb 19 14:58:23 2023 -0800

    Update .NET targets, and change OriginInternalUser.DOB field to a string

    LoginAsync() now fails because of a recent change to the month and day fields of the user's birthdate to asterisks (**), since this is no longer a valid DateTime.

commit e42d115
Merge: 2545bc5 fb83442
Author: Nutzzz <enussbaum@hotmail.com>
Date:   Sun Feb 19 14:23:12 2023 -0800

    Merge commit 'fb83442edf9d559f7cb6800881ba17313a34fe59' as 'PureOrigin.API'

commit fb83442
Author: Nutzzz <enussbaum@hotmail.com>
Date:   Sun Feb 19 14:23:12 2023 -0800

    Squashed 'PureOrigin.API/' content from commit 15eb190

    git-subtree-dir: PureOrigin.API
    git-subtree-split: 15eb1905204e685c0b77e5f115687e48fcbe5967

commit 2545bc5
Author: Nutzzz <enussbaum@hotmail.com>
Date:   Thu Feb 16 16:07:04 2023 -0800

    More Humble fixes

    * Show Collection games as not-installed if Choice subscription is inactive
    * Fix install
    * Add option whether to use Humble App (vs .exe) to launch games or not

commit 9360048
Author: Nutzzz <enussbaum@hotmail.com>
Date:   Wed Feb 15 20:55:07 2023 -0800

    Humble fixes

    * Incorrect capitalization sometimes resulted in blank ID
    * Humble App is command line app, needs a workaround like itch

commit 3987bb8
Author: Nutzzz <enussbaum@hotmail.com>
Date:   Mon Feb 6 13:59:54 2023 -0800

    Comment out Humble image download for now

commit 7d65831
Author: Nutzzz <enussbaum@hotmail.com>
Date:   Mon Feb 6 13:48:25 2023 -0800

    Add Humble App platform

commit 34e32da
Author: Nutzzz <enussbaum@hotmail.com>
Date:   Sat Feb 4 00:23:42 2023 -0800

    Add "Client" to "Game Jolt" description

commit 7a2756c
Merge: ae4b456 0672d69
Author: Nutzzz <enussbaum@hotmail.com>
Date:   Sat Feb 4 00:18:15 2023 -0800

    Merge branch 'master' of https://github.com/Nutzzz/GLC

commit ae4b456
Author: Nutzzz <enussbaum@hotmail.com>
Date:   Sat Feb 4 00:11:31 2023 -0800

    Add Game Jolt platform

commit 0672d69
Author: Nutzzz <enussbaum@hotmail.com>
Date:   Wed Feb 1 14:22:41 2023 -0800

    Fix EA Desktop implementation (Solaire#67)

    * Fix EA Desktop implementation

    Also:
    * Use the proper method to select between 32-bit vs. 64-bit Registry
    * Fix some variable capitalization
    * Upgrade a few NuGet packages

    * Update to 1.3.1, add references to Rockstar

    (I am assuming Rockstar is working; I don't own any of their games.)

commit c6dde2f
Author: Nutzzz <enussbaum@hotmail.com>
Date:   Mon Jan 30 12:14:17 2023 -0800

    Update to 1.3.1, add references to Rockstar

    (I am assuming Rockstar is working; I don't own any of their games.)

commit f4d59c6
Author: Nutzzz <enussbaum@hotmail.com>
Date:   Mon Jan 30 10:45:18 2023 -0800

    Fix EA Desktop implementation

    Also:
    * Use the proper method to select between 32-bit vs. 64-bit Registry
    * Fix some variable capitalization
    * Upgrade a few NuGet packages

commit 1550eae
Author: Kacper <22472584+Solaire@users.noreply.github.com>
Date:   Wed Dec 28 23:52:46 2022 +0000

    Version 1.3.0 (Solaire#65)

commit 4d7be3c
Author: Nutzzz <enussbaum@hotmail.com>
Date:   Wed Dec 28 09:32:33 2022 -0800

    Update to .NET 7 and fix Plarium Play bug (Solaire#64)

    * Update Oculus.cs

    * Update Oculus.cs

    * Update to .NET 7

    Also update NuGet packages

    * Add "Bnet" prefix to Battlenet classes/enums for ProtoBuf contracts

    Also simplify where using used

    * Fix bug after Plarium Play update moved install location

    Also adds an experiment downloading .webp images from Plarium's site (though this format won't be supported until we move to a cross-platform image library)

    * Update GOG.cs

    * Update Config.cs

    * Update README.MD

    Also add EXIF image support, since it should apparently work

    * Make removal optional on StartGame() failure

    Also allow manual download of icon from Rockstar website

commit fc0c5e0
Author: Nutzzz <enussbaum@hotmail.com>
Date:   Mon Nov 14 16:21:26 2022 -0800

    Oops, commented out section in the unused Oculus GetUserName() was causing syntax error (Solaire#63)

    * Update Oculus.cs

    * Update Oculus.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Solaire Solaire Solaire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Nutzzz @Solaire