feat: add delegate.voters attribute #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core's Public API lacks an easy way to see how many wallets are voting for each delegate without querying each delegate's endpoint individually. This PR improves on this by adding a
delegate.votersattribute to all delegates, with the total number of wallets voting for that delegate. This information is now exposed via/api/delegatesand/api/delegates/{id}.This brings the same functionality as the @dpos-info/core-voter-count plugin but natively in Core and we would like to recognise, acknowledge and thank them their reference implementation. Implementing it natively in Core also means new search and sorting criteria has been added to the
/api/delegatesAPI endpoint for thevotersattribute and it will continue to work correctly with several upcoming changes to Solar which would otherwise break the plugin.