datamodel: add __check_metrics__()
#301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add helpfer function to determine if the select metrics are valid (e.g. if evaluating a deterministic forecast, then should use deterministic forecast metrics, not probabilistic).
dplarson
changed the title
__check_metrics__()__check_metrics__()
Remove the probabilistic forecasts from `__check_metrics__()` since they are not yet fully integrated into the `metrics.calculator` code.
|
@wholmgren This PR (adding the |
|
Looks good assuming we add follow up issue for probabilistic metrics. I think it's worth a quick note in the whats new file too. |
wholmgren
added
enhancement
|
Just opened issue #302 for checking probabilistic metrics and added a line to |
wholmgren
approved these changes
Jan 6, 2020
|
@alorenzo175 ok to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/source/api.rstfor API changes.docs/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).Adds helper function
__check_metrics__()to determine if the select metrics are valid (e.g. if evaluating a deterministic forecast, then should use deterministic forecast metrics, not probabilistic).