Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nwp.py #794

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

williamhobbs
Copy link

@williamhobbs williamhobbs commented Sep 13, 2022

  • Closes Some modifications for HRRR v5 #793 .
  • I am familiar with the contributing guidelines.
  • Tests added.
  • Updates entries to docs/source/api.rst for API changes.
  • Adds descriptions to appropriate "what's new" file in docs/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

The current NWP fetch process only grabs HRRR (hourly) out to 36 hours (for cycles where it goes out more than 18 hours), but HRRR has forecasts out to 48 hours (#793). This addresses that issue.

I would have also addressed the issue with RAP going out to 51 hours for some cycles, but I have not been able to successfully fetch RAP NWP files to test it (see #699), so I ignored that one.

I did run some quick tests with the changes to HRRR and I was able to successfully fetch and process grib files out to 48 hours for the relevant cycles. Someone let me know if documentation of that is needed. Similarly, I'm not sure what is needed for the checklist above, so let me know if I need to take other steps for tests, documentation, etc.

@dplarson
Copy link
Contributor

Thanks @williamhobbs. I'll start reviewing and can follow-up with any revisions needed, including what's needed for the checklist above.

Added an option for HRRR hourly to hourly mean using irradiance from the NWP.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants