Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for custom SSL context for registration requests #65

Closed
deadpassive opened this issue Sep 24, 2021 · 4 comments
Closed

Add option for custom SSL context for registration requests #65

deadpassive opened this issue Sep 24, 2021 · 4 comments

Comments

@deadpassive
Copy link

deadpassive commented Sep 24, 2021 •
edited

There is currently no option to set the SSL context to use for registration requests. In my case this is required as my SBA server requires a valid certificate.

Looking at the code here it doesn't look like it would be too difficult to pass in an SSL context to use for this in a similar way to registration_auth.
@michaelyaakoby
Copy link
Member

Hi @deadpassive, indeed it should be easy adding an option to provide your own context.

Hope to get this done soon.

michaelyaakoby pushed a commit that referenced this issue Sep 24, 2021
Allow using custom SSL context for registration requests
5c47fbc 
Pyctuator should support using custom `ssl.SSLContext` when registering
with HTTPS enabled Spring Boot Admin.

This is in addition to the option to disable certificate validation, that
should never be used except for testing, using the `PYCTUATOR_REGISTRATION_NO_CERT`
environment-variable.

Solves #65
@michaelyaakoby michaelyaakoby mentioned this issue Sep 24, 2021
Merged
@michaelyaakoby
Copy link
Member

@deadpassive , please take a look at #66 and tell me if that's what you need.

michaelyaakoby pushed a commit that referenced this issue Sep 25, 2021
@michaelyaakoby
Allow using custom SSL context for registration requests
0ff2b20 
Pyctuator should support using custom `ssl.SSLContext` when registering
with HTTPS enabled Spring Boot Admin.

This is in addition to the option to disable certificate validation, that
should never be used except for testing, using the `PYCTUATOR_REGISTRATION_NO_CERT`
environment-variable.

Solves #65
@michaelyaakoby
Copy link
Member

Fixed in v0.16.0

@deadpassive
Copy link
Author

Hi @michaelyaakoby - this looks exactly like what I need. Thanks for the swift response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@deadpassive @michaelyaakoby