Pycturator should allow disabling specifc endpoints #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #105 +/- ##
==========================================
+ Coverage 95.27% 95.36% +0.09%
==========================================
Files 29 30 +1
Lines 1184 1208 +24
==========================================
+ Hits 1128 1152 +24
Misses 56 56 ☔ View full report in Codecov by Sentry. |
michaelyaakoby
force-pushed
the
michael/disable-endpoints
branch
7 times, most recently
from
1fd5f99
to
86cc438
Compare
In order to disable pyctuator endpoints such as `/pyctuator/httptraces`, pyctuator now can be initialized with flags selecting endpoints that shouldn't be registered in SBA and should fail if queried (GET) directly. Fixes #92
michaelyaakoby
force-pushed
the
michael/disable-endpoints
branch
from
86cc438
to
3e850f7
Compare
michaelyaakoby
force-pushed
the
michael/disable-endpoints
branch
from
e0d1f27
to
2e40f46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to disable pyctuator endpoints such as
/pyctuator/httptraces, pyctuator now can be initialized with flags selecting endpoints that shouldn't be registered in SBA and should fail if queried (GET) directly.Fixes #92