Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wind pv salt tes #110

Merged
merged 8 commits into from
Sep 11, 2023
Merged

Wind pv salt tes #110

merged 8 commits into from
Sep 11, 2023

Conversation

arfontalvoANU
Copy link
Collaborator

Changes from the last merge:

  • on_charge minimum for m_flow_in in ScheduleLogic.mo
  • Fixed outlet boiler temperature
  • Adding an oversizing factor to the renewable output compared to the process heat input.
  • Fixing issue with empty tank thresholds inherited from Reference 2.
  • Update of the test case for the wind-pv-salt-TES system.

yewang726
yewang726 approved these changes Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@yewang726 yewang726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes were tested and didn't break any package.

The fail on the MSYS2 tests was not caused by this merge, but an issue with importing binascii in Python.

@yewang726 yewang726 closed this Sep 11, 2023
@yewang726 yewang726 reopened this Sep 11, 2023
@yewang726 yewang726 merged commit 48dc684 into master Sep 11, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yewang726 yewang726 yewang726 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arfontalvoANU @yewang726