Fix sending of quotes and invoices

[pierredup]

When using the "Save and Send" button for quotes and invoices, they were never sent out.
Also fix attaching an invoice to a quote when accepting a quote.

[what-the-diff]

• Added typehints to the Transition class
• Removed unused variables from InvoiceCreateHandler and added a new one for MailerInterface
• Changed return types of __invoke methods in Send, AbstractInvoiceHandler and Transition classes to RedirectResponse
• Fixed typo in transition action name (accepted -> accepted)
• Set quote property on invoice when creating an invoice from a quote object
• Rename QuoteManager to QuoteMailer
• Move send logic from manager to mailer
• Add exception handling for sending email in the workflow listener and action handler (in case of invalid transition or transport error)
• Remove unused code from WorkFlowSubscriberTest::onQuoteAccepted() test method, as it is not used anymore after refactoring
• Added a new class QuoteMailer
• Updated the WorkFlowSubscriber to use this new mailer instead of sending emails directly from it
• Removed some duplicate code in tests for creating the subscriber object and added test coverage for QuoteMailer

[codecov]

Codecov Report

Patch coverage: 29.41% and project coverage change: -0.51 ⚠️

Comparison is base (080e88e) 50.84% compared to head (7403468) 50.33%.

Additional details and impacted files

@@             Coverage Diff              @@
##              2.2.x     #666      +/-   ##
============================================
- Coverage     50.84%   50.33%   -0.51%     
- Complexity     2204     2211       +7     
============================================
  Files           411      411              
  Lines          7559     7575      +16     
============================================
- Hits           3843     3813      -30     
- Misses         3716     3762      +46     

Flag	Coverage Δ
unittests	50.33% <29.41%> (-0.51%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/InvoiceBundle/Action/Transition.php	0.00% <0.00%> (ø)
src/InvoiceBundle/Action/Transition/Send.php	0.00% <0.00%> (ø)
...oiceBundle/Form/Handler/AbstractInvoiceHandler.php	0.00% <0.00%> (-100.00%)	⬇️
src/QuoteBundle/Action/Transition.php	0.00% <0.00%> (ø)
src/QuoteBundle/Action/Transition/Send.php	0.00% <0.00%> (ø)
src/QuoteBundle/Mailer/QuoteMailer.php	22.72% <0.00%> (ø)
src/QuoteBundle/Listener/WorkFlowSubscriber.php	96.15% <80.00%> (-3.85%)	⬇️
src/InvoiceBundle/Manager/InvoiceManager.php	60.65% <100.00%> (+1.33%)	⬆️
src/MailerBundle/Factory/MailerConfigFactory.php	100.00% <100.00%> (ø)
.../QuoteBundle/Form/Handler/AbstractQuoteHandler.php	0.00% <0.00%> (-100.00%)	⬇️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.