Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove primary key from ManyToMany join tables #703

Merged
merged 1 commit into from Mar 25, 2023
Merged

Conversation

pierredup
Copy link
Member

The primary key needs to be unique in a table, and since we can have multiple entities with the same ID,
this causes errors when creating related entities with the same ID.

@pierredup pierredup added the bug label Mar 25, 2023
@pierredup pierredup added this to the 2.2.1 milestone Mar 25, 2023
@pierredup pierredup self-assigned this Mar 25, 2023
@pierredup pierredup enabled auto-merge (rebase) March 25, 2023 10:34
@what-the-diff
Copy link

what-the-diff bot commented Mar 25, 2023

PR Summary

  • Removal of primary keys for multiple contact tables The primary keys have been removed from the quote_contact, invoice_contact, and recurringinvoice_contact tables to improve database flexibility.

@github-advanced-security
Copy link

You have successfully added a new QDJS configuration project/qodana. As part of the setup process, we have scanned this repository and found 879 existing alerts. Please check the repository Security tab to see all alerts.

@codecov
Copy link

codecov bot commented Mar 25, 2023

Codecov Report

Patch coverage: 25.40% and project coverage change: +0.88 🎉

Comparison is base (ea37487) 50.76% compared to head (fb6a3e3) 51.65%.

Additional details and impacted files
@@             Coverage Diff              @@
##              2.2.x     #703      +/-   ##
============================================
+ Coverage     50.76%   51.65%   +0.88%     
+ Complexity     2203     2142      -61     
============================================
  Files           410      429      +19     
  Lines          7560     8120     +560     
============================================
+ Hits           3838     4194     +356     
- Misses         3722     3926     +204     
Flag Coverage Δ
unittests 51.65% <25.40%> (+0.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/ClientBundle/Entity/AdditionalContactDetail.php 52.63% <ø> (ø)
src/ClientBundle/Entity/Address.php 0.00% <0.00%> (ø)
src/ClientBundle/Entity/Client.php 48.51% <ø> (-1.00%) ⬇️
src/ClientBundle/Entity/Contact.php 46.03% <0.00%> (-6.60%) ⬇️
src/ClientBundle/Entity/ContactType.php 28.12% <ø> (-2.18%) ⬇️
src/ClientBundle/Entity/Credit.php 62.50% <ø> (-2.21%) ⬇️
src/CoreBundle/Action/CreateCompany.php 0.00% <0.00%> (ø)
src/CoreBundle/Action/SelectCompany.php 0.00% <0.00%> (ø)
src/CoreBundle/Entity/Company.php 0.00% <0.00%> (ø)
src/CoreBundle/Form/Handler/CompanyFormHandler.php 0.00% <0.00%> (ø)
... and 49 more

... and 320 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pierredup pierredup merged commit 54b3eaf into 2.2.x Mar 25, 2023
14 of 15 checks passed
@pierredup pierredup deleted the fix-entity-save branch March 25, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant