Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BC] Replace entity IDs with UUID #741

Merged
merged 6 commits into from Apr 11, 2023
Merged

[BC] Replace entity IDs with UUID #741

merged 6 commits into from Apr 11, 2023

Conversation

pierredup
Copy link
Member

  • [BC] Remove Loggable
    • Loggable does not support composite identifiers, and the log table was not used anywhere
  • [BC] Replace entity IDs with UUID
    • Fixes issues with the custom id generator and trying to keep auto-increment IDs between each company

Loggable does not support composite identifiers, and the log table
was not used anywhere
@pierredup pierredup added the bug label Apr 11, 2023
@pierredup pierredup added this to the 2.2.1 milestone Apr 11, 2023
@pierredup pierredup self-assigned this Apr 11, 2023
@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Patch coverage: 46.28% and project coverage change: -1.40 ⚠️

Comparison is base (ea37487) 50.76% compared to head (ef9d6a9) 49.37%.

❗ Current head ef9d6a9 differs from pull request most recent head 2f94e32. Consider uploading reports for the commit 2f94e32 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##              2.2.x     #741      +/-   ##
============================================
- Coverage     50.76%   49.37%   -1.40%     
+ Complexity     2203     2175      -28     
============================================
  Files           410      434      +24     
  Lines          7560     8217     +657     
============================================
+ Hits           3838     4057     +219     
- Misses         3722     4160     +438     
Flag Coverage Δ
unittests 49.37% <46.28%> (-1.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ClientBundle/Action/Grid/Delete.php 0.00% <0.00%> (ø)
...rc/ClientBundle/Entity/AdditionalContactDetail.php 52.63% <0.00%> (ø)
src/ClientBundle/Entity/Address.php 0.00% <0.00%> (ø)
src/ClientBundle/Entity/Credit.php 62.50% <0.00%> (-2.21%) ⬇️
...le/Form/ViewTransformer/ContactTypeTransformer.php 0.00% <0.00%> (ø)
src/ClientBundle/Repository/ClientRepository.php 2.94% <ø> (-1.61%) ⬇️
src/ClientBundle/Test/Factory/ClientFactory.php 0.00% <0.00%> (ø)
src/CoreBundle/Action/CreateCompany.php 0.00% <0.00%> (ø)
src/CoreBundle/Action/SelectCompany.php 0.00% <0.00%> (ø)
src/CoreBundle/Form/Handler/CompanyFormHandler.php 0.00% <0.00%> (ø)
... and 69 more

... and 305 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

…-entity-ids

* '2.2.x' of github.com:SolidInvoice/SolidInvoice:
  Fix setting company when using the API (#702)
@pierredup pierredup merged commit ba35df4 into 2.2.x Apr 11, 2023
20 checks passed
@pierredup pierredup deleted the fix-entity-ids branch April 11, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant