Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding users to quotes and invoices #819

Merged
merged 1 commit into from May 10, 2023
Merged

Conversation

pierredup
Copy link
Member

Fixes #816

@pierredup pierredup added the bug label May 10, 2023
@pierredup pierredup added this to the 2.2.3 milestone May 10, 2023
@pierredup pierredup self-assigned this May 10, 2023
@what-the-diff

This comment was marked as resolved.

@pierredup pierredup enabled auto-merge (rebase) May 10, 2023 18:21
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch coverage: 56.73% and project coverage change: -0.04 ⚠️

Comparison is base (5db4606) 50.60% compared to head (4b495e3) 50.57%.

Additional details and impacted files
@@             Coverage Diff              @@
##              2.2.x     #819      +/-   ##
============================================
- Coverage     50.60%   50.57%   -0.04%     
- Complexity     2201     2208       +7     
============================================
  Files           439      439              
  Lines          8303     8240      -63     
============================================
- Hits           4202     4167      -35     
+ Misses         4101     4073      -28     
Flag Coverage Δ
unittests 50.57% <56.73%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ApiBundle/ApiTokenManager.php 100.00% <ø> (ø)
...le/Event/Listener/AuthenticationSuccessHandler.php 0.00% <ø> (ø)
.../Normalizer/AdditionalContactDetailsNormalizer.php 94.73% <ø> (ø)
...undle/Serializer/Normalizer/DiscountNormalizer.php 100.00% <ø> (ø)
src/ClientBundle/Action/Add.php 0.00% <ø> (ø)
src/ClientBundle/Action/Ajax/Address/Edit.php 0.00% <ø> (ø)
src/ClientBundle/Action/Ajax/Contact/Add.php 0.00% <ø> (ø)
src/ClientBundle/Action/Ajax/Contact/Edit.php 0.00% <ø> (ø)
src/ClientBundle/Action/Ajax/Delete.php 0.00% <ø> (ø)
src/ClientBundle/Action/Edit.php 0.00% <ø> (ø)
... and 172 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pierredup pierredup disabled auto-merge May 10, 2023 19:05
@pierredup pierredup merged commit b6d6052 into 2.2.x May 10, 2023
22 of 23 checks passed
@pierredup pierredup deleted the fix-invoice-users branch May 10, 2023 19:05
@hedho
Copy link
Contributor

hedho commented May 10, 2023

The setup now is all okay it asks to be generated a new user.

ERROR You need to select at least 1 user to attach to the Invoice
ERROR This value should not be blank.

Is still present eventhough the Client is selected!

brave_2ob4Uuo4uN

@pierredup
Copy link
Member Author

@hedho this fix isn't part of any release yet, it will be included once 2.2.3 is released

@pierredup pierredup mentioned this pull request May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants