Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting tax rates on invoices and quotes #820

Merged
merged 1 commit into from May 11, 2023
Merged

Conversation

pierredup
Copy link
Member

No description provided.

@pierredup pierredup added bug php Pull requests that update Php code labels May 11, 2023
@pierredup pierredup added this to the 2.2.3 milestone May 11, 2023
@pierredup pierredup self-assigned this May 11, 2023
@what-the-diff
Copy link

what-the-diff bot commented May 11, 2023

PR Summary

  • Removed ContactTypeTransformer class
    Replaced with more efficient EntityUuidTransformer
  • Updated Select2Type
    Now uses non-deprecated ChoiceType as parent
  • Introduced form_help block
    Simplifies help text display in forms and replaced old functionality
  • Resolved TaxEntity autowiring issues
    Fixed missing services definition leading to previous issues

@pierredup pierredup changed the title Remove test user details from full build Fix setting tax rates on invoices and quotes May 11, 2023
@pierredup pierredup enabled auto-merge (rebase) May 11, 2023 10:47
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Patch coverage: 54.44% and project coverage change: -0.08 ⚠️

Comparison is base (5db4606) 50.60% compared to head (90196e2) 50.53%.

Additional details and impacted files
@@             Coverage Diff              @@
##              2.2.x     #820      +/-   ##
============================================
- Coverage     50.60%   50.53%   -0.08%     
- Complexity     2201     2207       +6     
============================================
  Files           439      438       -1     
  Lines          8303     8242      -61     
============================================
- Hits           4202     4165      -37     
+ Misses         4101     4077      -24     
Flag Coverage Δ
unittests 50.53% <54.44%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ApiBundle/ApiTokenManager.php 100.00% <ø> (ø)
...le/Event/Listener/AuthenticationSuccessHandler.php 0.00% <ø> (ø)
.../Normalizer/AdditionalContactDetailsNormalizer.php 94.73% <ø> (ø)
...undle/Serializer/Normalizer/DiscountNormalizer.php 100.00% <ø> (ø)
src/ClientBundle/Action/Add.php 0.00% <ø> (ø)
src/ClientBundle/Action/Ajax/Address/Edit.php 0.00% <ø> (ø)
src/ClientBundle/Action/Ajax/Contact/Add.php 0.00% <ø> (ø)
src/ClientBundle/Action/Ajax/Contact/Edit.php 0.00% <ø> (ø)
src/ClientBundle/Action/Ajax/Delete.php 0.00% <ø> (ø)
src/ClientBundle/Action/Edit.php 0.00% <ø> (ø)
... and 177 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pierredup pierredup disabled auto-merge May 11, 2023 11:06
@pierredup pierredup merged commit 80b1c84 into 2.2.x May 11, 2023
22 of 23 checks passed
@pierredup pierredup deleted the fix-tax-saving branch May 11, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant