Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Up - 2.2.x into 2.3.x #822

Closed
wants to merge 5 commits into from
Closed

Conversation

pierredup
Copy link
Member

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented May 15, 2023

PR Summary

  • Removed and Refactored Class Transformers
    Removed the ContactTypeTransformer class and moved EntityUuidTransformer to CoreBundle with a new name.

  • Updated UserToContact Transformer
    Changed the transformer to use getId() instead of __toString() for UUIDs (includes backward compatibility break).

  • Enhanced TaxEntity Form Type
    Added help_html option in TaxEntity form type for rendering HTML in tax rate explanation text without escaping it.

  • Renamed Select2 Widget Block Prefix
    Renamed the block prefix from select2 to select_widget to avoid issues when using ChoiceType::class as parent field type.

…ge-up/2.2.x-in-2.3.x

* '2.3.x' of github.com:SolidInvoice/SolidInvoice: (120 commits)
  Suppress zip output
  Fix workflow syntax
  Run build against milestone version
  Save archives directly to dist dir
  Remove test user details from full build
  Bump symfony/mailgun-mailer from 5.4.21 to 6.2.10
  Bump webpack from 5.81.0 to 5.82.0
  Bump twig/extra-bundle from 3.5.1 to 3.6.0
  Bump mpociot/vat-calculator from 3.1.1 to 3.3.0
  Bump sass from 1.62.0 to 1.62.1
  Bump zenstruck/foundry from 1.23.0 to 1.31.0
  Bump laminas/laminas-zendframework-bridge from 1.6.1 to 1.7.0
  Bump cloudinary from 1.36.2 to 1.36.4
  Bump @babel/eslint-parser from 7.21.3 to 7.21.8
  Bump @babel/preset-env from 7.21.4 to 7.21.5
  Bump step-security/harden-runner from 2.3.1 to 2.4.0
  Bump github/codeql-action from 2.3.2 to 2.3.3
  Remove phpstan-ignore annotation since debugging is enabled in GH actions
  Fix TimestampableListener service config
  Fix CS
  ...
@pierredup pierredup enabled auto-merge (rebase) May 15, 2023 13:10
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Patch coverage: 52.72% and project coverage change: +0.22 🎉

Comparison is base (558daa1) 50.51% compared to head (2ac915b) 50.74%.

Additional details and impacted files
@@             Coverage Diff              @@
##              2.3.x     #822      +/-   ##
============================================
+ Coverage     50.51%   50.74%   +0.22%     
+ Complexity     2208     2178      -30     
============================================
  Files           437      437              
  Lines          8241     8025     -216     
============================================
- Hits           4163     4072      -91     
+ Misses         4078     3953     -125     
Flag Coverage Δ
unittests 50.74% <52.72%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...le/Event/Listener/AuthenticationSuccessHandler.php 0.00% <0.00%> (ø)
src/ApiBundle/Security/ApiTokenAuthenticator.php 66.66% <ø> (-2.39%) ⬇️
src/ClientBundle/Action/Add.php 0.00% <0.00%> (ø)
src/ClientBundle/Action/Ajax/Address/Edit.php 0.00% <0.00%> (ø)
src/ClientBundle/Action/Ajax/Contact/Add.php 0.00% <0.00%> (ø)
src/ClientBundle/Action/Ajax/Contact/Edit.php 0.00% <0.00%> (ø)
src/ClientBundle/Action/Ajax/Credit.php 0.00% <0.00%> (ø)
src/ClientBundle/Action/Ajax/Delete.php 0.00% <0.00%> (ø)
src/ClientBundle/Action/Ajax/Info.php 0.00% <0.00%> (ø)
src/ClientBundle/Action/Edit.php 0.00% <0.00%> (ø)
... and 104 more

... and 152 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants