Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out PDO drivers not supported by Doctrine during installation #835

Merged
merged 6 commits into from May 18, 2023

Conversation

pierredup
Copy link
Member

No description provided.

@pierredup pierredup added the bug label May 15, 2023
@pierredup pierredup added this to the 2.2.4 milestone May 15, 2023
@pierredup pierredup self-assigned this May 15, 2023
@what-the-diff
Copy link

what-the-diff bot commented May 15, 2023

PR Summary

  • Refactored getForm method for PHP 8.0
    The getForm method now utilizes the new array functions available in PHP 8.0, making the code more efficient and up-to-date.
  • Updated try/catch block in Install class
    The __invoke() method of the Install class now catches Throwable instead of MigrationException, allowing for better error handling and increased robustness.

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Patch coverage: 48.35% and project coverage change: -0.09 ⚠️

Comparison is base (5db4606) 50.60% compared to head (706ddf2) 50.52%.

Additional details and impacted files
@@             Coverage Diff              @@
##              2.2.x     #835      +/-   ##
============================================
- Coverage     50.60%   50.52%   -0.09%     
- Complexity     2201     2208       +7     
============================================
  Files           439      438       -1     
  Lines          8303     8228      -75     
============================================
- Hits           4202     4157      -45     
+ Misses         4101     4071      -30     
Flag Coverage Δ
unittests 50.52% <48.35%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ApiBundle/ApiTokenManager.php 100.00% <ø> (ø)
...le/Event/Listener/AuthenticationSuccessHandler.php 0.00% <ø> (ø)
.../Normalizer/AdditionalContactDetailsNormalizer.php 94.73% <ø> (ø)
...undle/Serializer/Normalizer/DiscountNormalizer.php 100.00% <ø> (ø)
src/ClientBundle/Action/Add.php 0.00% <ø> (ø)
src/ClientBundle/Action/Ajax/Address/Edit.php 0.00% <ø> (ø)
src/ClientBundle/Action/Ajax/Contact/Add.php 0.00% <ø> (ø)
src/ClientBundle/Action/Ajax/Contact/Edit.php 0.00% <ø> (ø)
src/ClientBundle/Action/Ajax/Delete.php 0.00% <ø> (ø)
src/ClientBundle/Action/Edit.php 0.00% <ø> (ø)
... and 185 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

The currency is set when creating an initial company, so it's not
necessary to set it during installaition.
@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@pierredup pierredup merged commit 2a15a29 into 2.2.x May 18, 2023
21 of 23 checks passed
@pierredup pierredup deleted the installation-improvements branch May 18, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant