Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix actions dropdown on the datagrid #837

Merged
merged 1 commit into from May 18, 2023
Merged

Fix actions dropdown on the datagrid #837

merged 1 commit into from May 18, 2023

Conversation

pierredup
Copy link
Member

Partially fixes #833

@pierredup pierredup added the bug label May 15, 2023
@pierredup pierredup added this to the 2.2.4 milestone May 15, 2023
@pierredup pierredup self-assigned this May 15, 2023
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch coverage: 54.44% and project coverage change: -0.08 ⚠️

Comparison is base (5db4606) 50.60% compared to head (1c640ae) 50.53%.

Additional details and impacted files
@@             Coverage Diff              @@
##              2.2.x     #837      +/-   ##
============================================
- Coverage     50.60%   50.53%   -0.08%     
- Complexity     2201     2207       +6     
============================================
  Files           439      438       -1     
  Lines          8303     8242      -61     
============================================
- Hits           4202     4165      -37     
+ Misses         4101     4077      -24     
Flag Coverage Δ
unittests 50.53% <54.44%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ApiBundle/ApiTokenManager.php 100.00% <ø> (ø)
...le/Event/Listener/AuthenticationSuccessHandler.php 0.00% <ø> (ø)
.../Normalizer/AdditionalContactDetailsNormalizer.php 94.73% <ø> (ø)
...undle/Serializer/Normalizer/DiscountNormalizer.php 100.00% <ø> (ø)
src/ClientBundle/Action/Add.php 0.00% <ø> (ø)
src/ClientBundle/Action/Ajax/Address/Edit.php 0.00% <ø> (ø)
src/ClientBundle/Action/Ajax/Contact/Add.php 0.00% <ø> (ø)
src/ClientBundle/Action/Ajax/Contact/Edit.php 0.00% <ø> (ø)
src/ClientBundle/Action/Ajax/Delete.php 0.00% <ø> (ø)
src/ClientBundle/Action/Edit.php 0.00% <ø> (ø)
... and 177 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pierredup pierredup merged commit 25df171 into 2.2.x May 18, 2023
22 of 23 checks passed
@pierredup pierredup deleted the fix-grid-dropdown branch May 18, 2023 12:15
@pierredup pierredup mentioned this pull request May 18, 2023
@davi1td
Copy link

davi1td commented Jun 18, 2023

Hi, is "overflow: visible;" added to src/DataGridBundle/Resources/public/scss/grid.scss
the only thing needed? cause I added that to my running 2.2.3-full to no avail, still not working.
Thanks
-Tom

@pierredup
Copy link
Member Author

@davi1td When making any changes to the scss file, the assets needs to be compiled again. You would need to install Yarn, then in the root directory run yarn install followed by yarn build. This should build all the assets again and the changes should then be visible in the app

@davi1td
Copy link

davi1td commented Jun 19, 2023

I might just wait till released and on docker, any idea when that might be?

@pierredup
Copy link
Member Author

Hopefully in the next week or two. There is one more bugfix that I would like to get into the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants