Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Github Worfklows #854

Merged
merged 9 commits into from
May 30, 2023
Merged

Update Github Worfklows #854

merged 9 commits into from
May 30, 2023

Conversation

pierredup
Copy link
Member

Fixes #801

@what-the-diff
Copy link

what-the-diff bot commented May 29, 2023

PR Summary

  • Egress-policy updated
    The egress-policy was updated from 'audit' to 'block' in several workflow files, improving security by preventing unauthorized data transfer.

@varunsh-coder
Copy link

H @pierredup, I am one of the maintainers of harden-runner. I see that you are trying to change the egress-policy to block mode.

For block mode, you also need to specify the allowed-endpoints, which you can see from a previous run of Harden-runner in audit mode.
e.g. for automatic-release.yml, the insights URL with audit mode is https://app.stepsecurity.io/github/SolidInvoice/SolidInvoice/actions/runs/4980521965 and has the recommended egress policy.

Screen Shot 2023-05-29 at 6 43 29 AM

The insights URL can be seen in the markdown summary for a workflow run.
https://github.com/SolidInvoice/SolidInvoice/actions/runs/4980521965

Screen Shot 2023-05-29 at 6 39 53 AM

@pierredup
Copy link
Member Author

Thanks @varunsh-coder!

@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (706ddf2) 50.52% compared to head (c3a6221) 50.52%.

Additional details and impacted files
@@            Coverage Diff            @@
##              2.2.x     #854   +/-   ##
=========================================
  Coverage     50.52%   50.52%           
  Complexity     2208     2208           
=========================================
  Files           438      438           
  Lines          8228     8228           
=========================================
  Hits           4157     4157           
  Misses         4071     4071           
Flag Coverage Δ
unittests 50.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@varunsh-coder
Copy link

Thanks @varunsh-coder!

Welcome! We also added support for wildcard domains recently. You can also use a wildcard if you notice multiple allowed-endpoints for the same sub-domains. More details in the docs.

@pierredup pierredup merged commit 4e5db9e into 2.2.x May 30, 2023
12 of 13 checks passed
@pierredup pierredup deleted the update-workflows branch May 30, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants