Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add email subject to password reset request email #934

Merged
merged 1 commit into from Sep 7, 2023

Conversation

pierredup
Copy link
Member

No description provided.

@pierredup pierredup added the bug label Sep 7, 2023
@pierredup pierredup added this to the 2.2.6 milestone Sep 7, 2023
@pierredup pierredup self-assigned this Sep 7, 2023
@what-the-diff
Copy link

what-the-diff bot commented Sep 7, 2023

PR Summary

  • Introduction of a Subject Line in Password Reset Emails
    This change ensures that every email sent to users for password reset requests now includes a subject line. This will make these emails more recognisable and easier to search for in users' inboxes, improving user experience.

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.02% ⚠️

Comparison is base (5d115d0) 50.97% compared to head (1e1ae3b) 50.95%.
Report is 6 commits behind head on 2.2.x.

Additional details and impacted files
@@             Coverage Diff              @@
##              2.2.x     #934      +/-   ##
============================================
- Coverage     50.97%   50.95%   -0.02%     
  Complexity     2229     2229              
============================================
  Files           442      442              
  Lines          8295     8295              
============================================
- Hits           4228     4227       -1     
- Misses         4067     4068       +1     
Flag Coverage Δ
unittests 50.95% <66.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/UserBundle/Email/ResetPasswordEmail.php 0.00% <0.00%> (ø)
src/MailerBundle/Factory/MailerConfigFactory.php 87.50% <100.00%> (-0.74%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierredup pierredup merged commit 538de83 into 2.2.x Sep 7, 2023
17 of 20 checks passed
@pierredup pierredup deleted the reset-password-subject branch September 7, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant