Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update required node version to 18 #969

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Update required node version to 18 #969

merged 3 commits into from
Nov 3, 2023

Conversation

pierredup
Copy link
Member

No description provided.

Copy link

what-the-diff bot commented Nov 3, 2023

PR Summary

  • Update to Node Version reference in GitHub Workflows
    The configuration for automated releases, code style checks, and unit tests in GitHub workflows has been adjusted. The workflow now references the Node version from a separate file, .nvmrc, instead of having it hard-coded. This change improves maintainability by centralizing the Node version specification.

  • Node Version Update in .nvmrc file
    The Node.js version specified in the .nvmrc file has been updated from version 14 to 18. This update enables our projects to take advantage of the latest features, performance improvements, and security patches from the newer version of Node.js.

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8501546) 50.97% compared to head (15a3322) 50.97%.
Report is 4 commits behind head on 2.3.x.

Additional details and impacted files
@@            Coverage Diff            @@
##              2.3.x     #969   +/-   ##
=========================================
  Coverage     50.97%   50.97%           
  Complexity     2213     2213           
=========================================
  Files           442      442           
  Lines          8137     8137           
=========================================
  Hits           4148     4148           
  Misses         3989     3989           
Flag Coverage Δ
unittests 50.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierredup pierredup self-assigned this Nov 3, 2023
@pierredup pierredup added this to the 2.3.0 milestone Nov 3, 2023
@pierredup pierredup merged commit 81cb8f5 into 2.3.x Nov 3, 2023
12 checks passed
@pierredup pierredup deleted the update-node-version branch November 3, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant