Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect option when adding TaxType to item #982

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

pierredup
Copy link
Member

Fixes #981

Copy link

what-the-diff bot commented Nov 22, 2023

PR Summary

  • Modification to ItemType.php
    In the ItemType.php file located in the src/QuoteBundle/Form/Type directory, there is an adjustment involving the removal of the 'class' => Tax::class, line. This impacts the TaxEntityType::class field options array.

  • Introduction of ItemTypeTest.php
    A new testing file named ItemTypeTest.php has been added to src/QuoteBundle/Tests/Form/Type. This contains a test for the submission of a form which includes form data creation and verification of correct data form population.

  • The testing of the Item object
    Additionally, an Item object is created with the same data to ensure the form data and Item object are identical.

  • SetUp operations and registration
    Necessary setUp code is added as part of the testing process, which includes producing a currency object and registering the ItemType form with the form factory.

  • New directory for test files
    This test file is placed in a newly created directory Tests/Form/Type.

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 45 lines in your changes are missing coverage. Please review.

Comparison is base (5d115d0) 50.97% compared to head (0a8722a) 50.79%.
Report is 28 commits behind head on 2.2.x.

Files Patch % Lines
...le/EventSubscriber/CronScheduleEventSubscriber.php 0.00% 35 Missing ⚠️
src/CoreBundle/Config/Loader/EnvLoader.php 63.63% 4 Missing ⚠️
src/CoreBundle/ConfigWriter.php 0.00% 1 Missing ⚠️
src/CoreBundle/Repository/VersionRepository.php 0.00% 1 Missing ⚠️
src/InstallBundle/Action/Install.php 0.00% 1 Missing ⚠️
src/InstallBundle/Command/InstallCommand.php 0.00% 1 Missing ⚠️
src/UserBundle/Email/ResetPasswordEmail.php 0.00% 1 Missing ⚠️
src/UserBundle/Repository/UserRepository.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              2.2.x     #982      +/-   ##
============================================
- Coverage     50.97%   50.79%   -0.18%     
- Complexity     2229     2240      +11     
============================================
  Files           442      443       +1     
  Lines          8295     8339      +44     
============================================
+ Hits           4228     4236       +8     
- Misses         4067     4103      +36     
Flag Coverage Δ
unittests 50.79% <32.83%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierredup pierredup changed the title Automatically bump version info when releasing new version @pierredup Fix incorrect option when adding TaxType to item Nov 22, 2023
@pierredup pierredup changed the title @pierredup Fix incorrect option when adding TaxType to item Fix incorrect option when adding TaxType to item Nov 22, 2023
@pierredup pierredup merged commit e84b6fc into 2.2.x Nov 22, 2023
15 of 20 checks passed
@pierredup pierredup deleted the fix-item-form branch November 22, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant