Move trustedApplications into basicPreferences #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megoth
approved these changes
Aug 27, 2019
There was a problem hiding this comment.
LGTM
The only problem I saw was some missing styles on headers - but this is not a problem with the work here, this is the result of earlier work. I've created an issue for it - SolidOS/mashlib#66.
megoth
added
the
release-minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes everything but the
renderfunction from the trustedApplications Pane definition, and exports that.trustedApplicationsPane.tslooks like a large diff, but the only change is the removal of the unusedsubjectparameter, and changing the indentation and function name.Fixes #151.