Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json fix? #378

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

package.json fix? #378

wants to merge 3 commits into from

Conversation

chunt007
Copy link
Contributor

On Windows 10 in VSCode, solid-panes will not start and will give you a ./ error, unless you revise the following from

"./timestamp.sh > src/versionInfo.ts && eslint 'src/versionInfo.ts'

to

"build-version": "eslint --fix",

Files like profileFormText.ttl may show up gray without proper syntax highlighting in code editors. For VSCode, I needed an extension.

Just adding a suggestion so a new comer or someone playing around with SPARQL and RDF related things, doesn't think they have to operate completely in gray colored code!
Comment on lines +80 to +81
If you have trouble seeing syntax highlighting for SPARQL, Turtle, TriG, N-Triples, N-Quads, etc...
Try installing an extension! For VSCode, there are many, but a great one is RDFox Syntax Highlighting.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you have trouble seeing syntax highlighting for SPARQL, Turtle, TriG, N-Triples, N-Quads, etc...
Try installing an extension! For VSCode, there are many, but a great one is RDFox Syntax Highlighting.
If you have trouble seeing syntax highlighting for SPARQL, Turtle, TriG, N-Triples, N-Quads, etc.,
try installing an extension! For VSCode, there are many; one that we've used is
[RDFox Syntax Highlighting](https://marketplace.visualstudio.com/items?itemName=rdfox.rdfox-rdf).

@@ -10,7 +10,7 @@
"build-lib": "npm run build-form && babel src -d lib --source-maps --extensions '.ts,.js'",
"build-dev": "webpack --progress --mode=development",
"build-types": "tsc --emitDeclarationOnly",
"build-version": "./timestamp.sh > src/versionInfo.ts && eslint 'src/versionInfo.ts' --fix",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This replaces whatever the build-version script did before by calling timestamp.sh with just a call to eslint. Does not seem right to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure as to why VSCode throws off that error, but in the mean time, perhaps we could use it as a cautionary suggestion to Windows 10 users? If it doesn't seem right, then maybe it is not. Should the suggestion instead go the readme?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently the dev setup seems not to be Windows compatible. At least the timestamp.sh would need to change if we want to make the build run under windows. There might be more changes needed. Under Windows you could try using WSL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants