Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data source option #537

Merged
merged 2 commits into from
Apr 6, 2023
Merged

data source option #537

merged 2 commits into from
Apr 6, 2023

Conversation

bourgeoa
Copy link
Contributor

@bourgeoa bourgeoa commented Mar 24, 2023 •
edited
Loading

Added a check on the following triple :

 form ui:options "search-full-store"

different solution can also be used like .

form ui:search-full-store true

Or anything along this idea.

@bourgeoa
Copy link
Contributor Author

I just saw that ui:Options is already used. Then may be that lower case options is a bad idea.
I am not sure of the ui predicate either.

I found the rdf:Property in such cas we can use :

form rdf:Property "search-full-store"

@bourgeoa bourgeoa linked an issue Mar 24, 2023 that may be closed by this pull request
Form choice field can't find implicit members of a class when subclasses are defined in a separate ontology document #535
Closed
@bourgeoa bourgeoa self-assigned this Mar 24, 2023
timea-solid
timea-solid approved these changes Mar 26, 2023
View reviewed changes
Copy link
Member

@timea-solid timea-solid left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fine. We shall test on test server. Elegant solution.

@bourgeoa bourgeoa mentioned this pull request Mar 26, 2023
Closed
@bourgeoa bourgeoa linked an issue Mar 26, 2023 that may be closed by this pull request
what options triple can be used in solid-ui #539
Closed
@bourgeoa
Copy link
Contributor Author

following SolisOS today's meeting

@bourgeoa bourgeoa merged commit f9084b4 into main Apr 6, 2023
@bourgeoa bourgeoa deleted the formChoice#535 branch April 6, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timea-solid timea-solid timea-solid approved these changes

Assignees

@bourgeoa bourgeoa

Labels
None yet
Projects
SolidOS team tasks & Git issues
Status: Done
Milestone
No milestone
2 participants
@bourgeoa @timea-solid