Makefile dep fix and snapshot.commit cleanup #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
added 2 commits
April 18, 2016 20:57
bin_hdr.uart.elf requires linker.scr under certain conditions
Diffs against tag v2013.01 would not apply against u-boot-2013.01.tar.bz2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realize now that I should've made two separate pull requests, but I can only edit the comment of this one.
Commit 1:
I was getting this error when building this u-boot in Timesys Factory.
ld: cannot open linker script file linker.scr: No such file or directory
I concluded that the make target for bin_hdr.uart.elf was the culprit. Adding a dependency on linker.scr fixed the problem.
Commit 2:
I found that snapshot.commit in this repo matched the one from u-boot-2013.01.tar.bz2 from U-Boot FTP, but not the one in U-Boot's git tree. This means that patches generated in the following manner would not apply cleanly to u-boot-2013.01.tar.bz2:
git diff -a v2013.01 HEAD > file.patch