fix: selectCategoryIdByTree This is a no-op, memory leak

SolidZORO · Jun 5, 2020 · 2cdcff8 · 2cdcff8
1 parent ba160a2
commit 2cdcff8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/leaa-dashboard/src/components/SelectCategoryIdByTree/SelectCategoryIdByTree.tsx b/packages/leaa-dashboard/src/components/SelectCategoryIdByTree/SelectCategoryIdByTree.tsx
@@ -46,7 +46,7 @@ export const SelectCategoryIdByTree = (props: IProps) => {
         if (!isAjaxCancelled.current) setTree(res.data?.data);
       })
       .catch((err: IHttpError) => errorMsg(err.response?.data?.message || err.message))
-      .finally(() => setTreeLoading(false));
+      .finally(() => !isAjaxCancelled.current && setTreeLoading(false));
   };
 
   const onChange = (v?: string | string[] | null) => {

diff --git a/packages/leaa-dashboard/src/components/TagSearchBox/TagSearchBox.tsx b/packages/leaa-dashboard/src/components/TagSearchBox/TagSearchBox.tsx
@@ -62,7 +62,7 @@ export const TagSearchBox = forwardRef((props: IProps, ref: React.Ref<any>) => {
         // console.log(err.response?.data?.message || err.message);
         errorMsg(err.response?.data?.message || err.message);
       })
-      .finally(() => setLoading(false));
+      .finally(() => isAjaxCancelled.current && setLoading(false));
   };
 
   // eslint-disable-next-line react-hooks/exhaustive-deps