Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain blocks are always considered "wet" #111

Closed
Andre601 opened this issue Dec 1, 2021 · 8 comments
Closed

Certain blocks are always considered "wet" #111

Andre601 opened this issue Dec 1, 2021 · 8 comments
Assignees
Labels
bug fixed will appear in the next release

Comments

@Andre601
Copy link

Andre601 commented Dec 1, 2021

Some blocks always sound like as if they are wet, despite not being next to or underneath a watersource.

The following video showcases this. The block in question is a retextured Noteblock (Instrument "BIT", note 19) and while it sounds normal at 0:21 does it have the added wet sound effect at 0:55.

https://www.youtube.com/watch?v=9Aey3C4dm2I

The blockmap.json I use through a resource pack has brickstone set as sound for this particular note block.

The corresponding entry in the resource pack:
https://github.com/Andre601/Presence-Footsteps-x-Origin-Realms/blob/main/OriginRealms-x-Presence-Footsteps/assets/presencefootsteps/config/blockmap.json#L345

For clarity: The blocks are not underneath a water source, nor do they have one right next to or underneath them.

@Sollace
Copy link
Owner

Sollace commented Dec 1, 2021

Are there any blocks in that area with the waterlogged state?

Only other reason I would think it would produce mud sounds there is if it thought it was raining on that block.

The relevant line would be here:

Not sure if it appears in production logs, but can you see if it produces the message "Wet block detected: " in the game logs when this happens?

@Sollace
Copy link
Owner

Sollace commented Dec 1, 2021

btw I love those copper golems you have there.

@Sollace
Copy link
Owner

Sollace commented Dec 1, 2021

Also can you tell me what blocks are under that floor? There are certain blocks that have the mud sound in their foliage subtrate, that might be producing the sound through the floor.

@Andre601
Copy link
Author

Andre601 commented Dec 1, 2021

Are there any blocks in that area with the waterlogged state?

Only other reason I would think it would produce mud sounds there is if it thought it was raining on that block.

The relevant line would be here:

Not sure if it appears in production logs, but can you see if it produces the message "Wet block detected: " in the game logs when this happens?

Nope. The closest water source or waterlogged blocks (In this case waterlogged stonebrick stairs) are like 20+ blocks away and also on different heights.
Also, the latest logs do not have any mention of such a line when checking.

btw I love those copper golems you have there.

Yeah, they're nice. Part of the server I play on which added all Mobs from that vote to it.

Also can you tell me what blocks are under that floor? There are certain blocks that have the mud sound in their foliage subtrate, that might be producing the sound through the floor.

I checked, there is mostly stone, cobblestone and dirt, but not really anything else.

@Sollace
Copy link
Owner

Sollace commented Dec 2, 2021

@Andre601 Hm... Okay. Is there a way I can get onto that server to test what's happening?

@Andre601
Copy link
Author

Andre601 commented Dec 2, 2021

@Andre601 Hm... Okay. Is there a way I can get onto that server to test what's happening?

The server is public. IP is play.originrealms.com

You would need to craft those blocks yourself tho... Alternatively could I invite you to my realm/world to test out...

@Sollace
Copy link
Owner

Sollace commented Dec 2, 2021

@Andre601 Yeah, you can. If I can see the place you showcased in the video myself, it may help.

So far I haven't been able to reproduce your issue in singleplayer at all.

@Andre601
Copy link
Author

Andre601 commented Dec 2, 2021

Okay. I'm now on the server, so feel free to contact me there so that you can check it out.

Edit: No longer online on the server. Don't have enough time today. Made my realm public tho, so you should be able to do /realm tp Andre_601

@Sollace Sollace self-assigned this Dec 4, 2021
@Sollace Sollace added bug fixed will appear in the next release labels Dec 4, 2021
@Sollace Sollace closed this as completed Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fixed will appear in the next release
Projects
None yet
Development

No branches or pull requests

2 participants