Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration tests #588

Merged
merged 9 commits into from
May 18, 2022
Merged

Conversation

jevgenigeurtsen
Copy link
Contributor

@jevgenigeurtsen jevgenigeurtsen commented Mar 1, 2022

Updated integration_tests.sh;

  • Enabled execution of all integration tests
  • Disabled execution of cloud integration tests
  • Added another docker instance that has basic auth enabled
  • Added multiple collections/cores, just to the default docker instance, required by various integration tests

Solution;

  • Fixed failing integration tests
  • Added integration tests to SolrNet.Tests to verify if basic auth is working, for both sync and async requests
  • Lowered LightInject package version

@jevgenigeurtsen jevgenigeurtsen changed the title Fix/integration tests Fix running integration tests Mar 1, 2022
@jevgenigeurtsen jevgenigeurtsen changed the title Fix running integration tests Fix integration tests Mar 1, 2022
@jevgenigeurtsen
Copy link
Contributor Author

jevgenigeurtsen commented Mar 1, 2022

Wait for #586 to be merged so that I can use LightInject SolrNet extensions to test authentication with sync/async calls. Test code is already in IntegrationfixtureTestAuthtentication, but commented out.

@mausch
Copy link
Member

mausch commented May 15, 2022

Sorry for the delay here. Now that #586 has been merged could you rebase this?

@jevgenigeurtsen
Copy link
Contributor Author

Done. Let me know if there is anything I can do.

@mausch
Copy link
Member

mausch commented May 17, 2022

Hi, thanks but can you rebase it? I see you merged master into this branch, which is the opposite of what I wanted 🙂
i.e. cherry-pick your commits on top of master.

@jevgenigeurtsen
Copy link
Contributor Author

Ah my bad. I rebased this branch on master and cherry picked the needed commits onto it.

@mausch mausch merged commit 071d8b5 into SolrNet:master May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants