Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document POD annotations #151

Closed
akhon opened this issue Apr 12, 2019 · 5 comments
Closed

Document POD annotations #151

akhon opened this issue Apr 12, 2019 · 5 comments
Labels
chart documentation

Comments

@akhon
Copy link
Contributor

akhon commented Apr 12, 2019

These lines are not documented anywhere
https://github.com/Soluto/helm-charts/blob/master/charts/kamus/templates/deployment-encryptor.yaml#L26-L28

Please add few lines about those in helm and git readmes

Thanks!
@max-lobur
Copy link

Only here https://github.com/Soluto/helm-charts/blob/master/charts/kamus/values.yaml#L13-L14 but not in args table doc

@omerlh
Copy link
Contributor

omerlh commented Apr 13, 2019

My mistake - I should have noticed it when reviewing the PR, will take a look tomorrow!

@omerlh omerlh mentioned this issue Apr 14, 2019
Merged
@omerlh
Copy link
Contributor

omerlh commented Apr 14, 2019

Opened a PR to fix it, thanks!

@omerlh omerlh added the chart label Apr 14, 2019
@omerlh omerlh closed this as completed Apr 14, 2019
@max-lobur
Copy link

@omerlh look at https://github.com/norwoodj/helm-docs

@omerlh
Copy link
Contributor

omerlh commented Apr 15, 2019

Ohh this is nice! We'll definitely add it sometime in the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chart documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@akhon @max-lobur @omerlh