small refactors, change admin app name #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned remove tests parallelism
another attempt
fix smoketests entrypoint
attempt to fix smoke tests
nataly87s
reviewed
Jan 22, 2019
| - run (``` yarn start ```) - this might take a few minutes for the first time | ||
|
|
||
| - Clone the repo (``` git clone https://github.com/Soluto/tweek.git ```) | ||
| - [optional] Pull images, run ```yarn docker-compose pull --parallel``` (optional for getting started fast with Tweek as it's skip build) |
There was a problem hiding this comment.
"it's skip" -> "it skips"
| Using the API, use curl/postman to fire POST Request: | ||
| - http://api.dev.tweek.localtest.me:81/api/v1/context/user/john {"Country":"Canada"} | ||
|
|
||
| Tweek provide UI and rest api for editing context. |
There was a problem hiding this comment.
"Tweek provides a UI and REST API for editing context"
| - Set Identity Type to User | ||
| - Set User id to John | ||
| - Click enter | ||
| - Set value "Candada" for property Country |
services/authoring/src/server.ts
Outdated
| @@ -114,5 +114,6 @@ onUpdate$ | |||
| .subscribe(); | |||
|
|
|||
| gitRepoCreationPromiseWithTimeout.then(async () => await startServer()).catch((reason: any) => { | |||
| process.exit(1); | |||
There was a problem hiding this comment.
I think you need to log first and then exit
nataly87s
approved these changes
Jan 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1067