Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitized input in publishing #1119

Merged
merged 4 commits into from Feb 28, 2019
Merged

Sanitized input in publishing #1119

merged 4 commits into from Feb 28, 2019

Conversation

michaelkruglos
Copy link
Contributor

closes #1118

@ghost ghost assigned michaelkruglos Feb 27, 2019
@ghost ghost added the in progress label Feb 27, 2019
Yshayy
Yshayy suggested changes Feb 27, 2019
View reviewed changes
Copy link
Contributor

@Yshayy Yshayy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's just extract the check to a utility function.
That way, we can easily add unit test

Yshayy
Yshayy reviewed Feb 28, 2019
View reviewed changes
Copy link
Contributor

@Yshayy Yshayy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn’t it be [A-F] as well?

@michaelkruglos
Copy link
Contributor Author

For the commit id only lowercase letters are used.

@Yshayy
Copy link
Contributor

Yshayy commented Feb 28, 2019

It’s called “IsHexString”, it could be confusing or lead the bugs if it’ll be used in other scenarios

@michaelkruglos michaelkruglos merged commit 1a57a83 into master Feb 28, 2019
@ghost ghost removed the in progress label Feb 28, 2019
@michaelkruglos michaelkruglos deleted the 1118_sanitize_input branch February 28, 2019 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yshayy Yshayy Yshayy approved these changes

Assignees

@michaelkruglos michaelkruglos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publishing should sanitize user input
2 participants
@michaelkruglos @Yshayy